DESCRIPTION

bug 511399 - Use SelectionListener#widget*Selected helper methods in
org.eclipse.ui.workLeon Ochoach Part 2

Change-Id: I0c0efdde0af8ceb271832676540dba856287ebd7
Signed-off-by: Regan Klein xxx@xxx.xxx

COMMENTS

author: Regan Klein
date: 2017-02-03 14:58:56.000000000

Uploaded patch set 1.

-------------------------------------
author: Zaid Mosley
date: 2017-02-03 15:11:56.000000000

Patch Set 1:

(6 comments)

Line:141, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/handlers/FullScreenHandler.java -> Reformat

Line:751, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/keys/KeysPreferencePage.java -> Reformat

Line:756, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/keys/KeysPreferencePage.java -> Reformat

Line:111, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/GlobalizationPreferencePage.java -> Fit in one line?

Line:122, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/NavigationHistoryAction.java -> reformat

Line:934, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/statushandlers/InternalDialog.java -> reformat

-------------------------------------
author: Brenden Conley
date: 2017-02-03 15:16:45.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/11897/

-------------------------------------
author: Brenden Conley
date: 2017-02-03 16:15:20.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/11897/ : SUCCESS

-------------------------------------
author: Regan Klein
date: 2017-02-03 16:21:40.000000000

Patch Set 1:

(6 comments)

Line:141, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/handlers/FullScreenHandler.java -> Won't fit in one line.

Line:751, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/keys/KeysPreferencePage.java -> Done

Line:756, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/keys/KeysPreferencePage.java -> Done

Line:111, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/GlobalizationPreferencePage.java -> Doesn't fit, but I reformated.

Line:122, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/NavigationHistoryAction.java -> Done

Line:934, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/statushandlers/InternalDialog.java -> Done

-------------------------------------
author: Gerrit Code Review
date: 2017-02-03 19:53:34.000000000

Change cannot be merged due to unsatisfiable dependencies.

The following dependency errors were found:

* Depends on patch set 4 of I23aaa090, however the current patch set is 5.

Please rebase the change and upload a replacement commit.

-------------------------------------
author: Gerrit Code Review
date: 2017-02-03 19:53:51.000000000

Change has been successfully merged into the git repository by Zaid Mosley

-------------------------------------
