DESCRIPTION

Bug 510745 - Remove 4 blob listeners

Removes four Blob Listener instances.
Blob listeners are code smells that affect user interface code.

Change-Id: I4767cd3ed5c3f1abf3398fe8a834b2a513f85017
Signed-off-by: Jorden Gonzalez xxx@xxx.xxx

COMMENTS

author: Jorden Gonzalez
date: 2017-01-20 11:34:01.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2017-01-20 11:34:07.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/11737/

-------------------------------------
author: Brenden Conley
date: 2017-01-20 11:58:46.000000000

Patch Set 1: Code-Review-1

Build Unstable 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/11737/ : UNSTABLE

-------------------------------------
author: Jayvion Booth
date: 2017-01-20 12:06:54.000000000

Patch Set 1: Code-Review-1

(4 comments)

I'm not yet done with heap status review, but you can rework other things first.

Line:331, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/dialogs/EditorSelectionDialog.java -> This seem to be same code as below. Please don't exchange one code smell with even bigger one - code duplication. If the code is same, it must not be copied around.

Line:155, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/HeapStatus.java -> please use blocks for if/else

Line:191, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/FileEditorsPreferencePage.java -> not sure if this is gerrit, but please check indentation.

Line:225, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/FileEditorsPreferencePage.java -> not sure if this is gerrit, but please check indentation.

-------------------------------------
