DESCRIPTION

Bug 484398 - Create a programmatic way to define core expressions

Change-Id: I8027468e5b0d773c4bae43f4200d3e0e9d39a1fe
Signed-off-by: Nevaeh Wu xxx@xxx.xxx

COMMENTS

author: Krista Shepherd
date: 2017-01-11 17:30:18.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2017-01-11 17:30:24.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/11667/

-------------------------------------
author: Brenden Conley
date: 2017-01-11 17:34:44.000000000

Patch Set 1: Verified-1

Build Failed 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/11667/ : FAILURE

-------------------------------------
author: Teagan Marsh
date: 2017-01-12 16:01:51.000000000

Patch Set 1:

(4 comments)

I prefer something other than MJavaExpression since it's specifying a class.

Line:176, bundles/org.eclipse.e4.ui.model.workLeon Ochoach/src/org/eclipse/e4/ui/model/application/ui/basic/MPart.java -> This change seems unnecessary?

Line:77, bundles/org.eclipse.e4.ui.model.workLeon Ochoach/src/org/eclipse/e4/ui/model/application/ui/advanced/MPerspective.java -> This change seems unnecessary?

Line:325, bundles/org.eclipse.e4.ui.model.workLeon Ochoach/src/org/eclipse/e4/ui/model/application/descriptor/basic/MPartDescriptor.java -> These changes look unnecessary?

Line:25, bundles/org.eclipse.e4.ui.model.workLeon Ochoach/src/org/eclipse/e4/ui/model/application/ui/MJavaExpression.java -> I'm not a fan of the name.  There's no reason that we can't load a Scala class, or any other language that compiles down to a .class file.

-------------------------------------
author: Gerrit Code Review
date: 2017-03-01 22:16:34.000000000

Change has been successfully merged into the git repository by Krista Shepherd

-------------------------------------
