DESCRIPTION

Bug 486531 Resource (GDI-Handles) leak in ImageHyperlink

Fixes a resource leak (GDI Handles) in createDisabledImage() in
org.eclipse.ui.forms.widgets.ImageHyperlink. Replaced redundant code in
setEnabled method. Removed useless if(image==null) and added a missing
redraw() in setImage() so that setImage() works similar to
setText().Added a JUnit Test for the leak.

Change-Id: Iabb5c5bc345de5e707f89cdc0575f4ba604b8712
Signed-off-by: Anthony Pineda xxx@xxx.xxx

COMMENTS

author: Brenden Conley
date: 2016-12-01 13:18:23.000000000

Patch Set 8:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/11376/

-------------------------------------
author: Jayvion Booth
date: 2016-12-01 13:24:32.000000000

Patch Set 8:

(2 comments)

Line:104, tests/org.eclipse.ui.tests.forms/forms/org/eclipse/ui/tests/forms/util/ImageHyperlinkTest.java -> style nit: please place opening brace on same line with method name

Line:113, tests/org.eclipse.ui.tests.forms/forms/org/eclipse/ui/tests/forms/util/ImageHyperlinkTest.java -> Please use assertSame(prev.., get..)

-------------------------------------
author: Anthony Pineda
date: 2016-12-01 13:28:45.000000000

Patch Set 8:

Thanks for your suggestions to improve the patch. I will upload a new patch set.

-------------------------------------
author: Brenden Conley
date: 2016-12-01 14:24:00.000000000

Patch Set 8: Verified-1

Build Failed 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/11376/ : FAILURE

-------------------------------------
author: Gerrit Code Review
date: 2016-12-01 15:06:15.000000000

Change has been successfully merged into the git repository by Jayvion Booth

-------------------------------------
