DESCRIPTION

Bug 486531 Resource (GDI-Handles) leak in ImageHyperlink

Fixes a resource leak (GDI Handles) in createDisabledImage() in
org.eclipse.ui.forms.widgets.ImageHyperlink. Replaced redundant code in
setEnabled method. Removed useless if(image==null) and added a missing
redraw() in setImage() so that setImage() works similar to
setText(). Added a JUnit Test for the leak.

Change-Id: Iabb5c5bc345de5e707f89cdc0575f4ba604b8712
Signed-off-by: Anthony Pineda xxx@xxx.xxx
Signed-off-by: Jayvion Booth xxx@xxx.xxx

COMMENTS

author: Jayvion Booth
date: 2016-12-01 13:46:28.000000000

Uploaded patch set 10.

-------------------------------------
author: Jayvion Booth
date: 2016-12-01 13:47:46.000000000

Patch Set 10: Code-Review+2

OK for merge, just waiting for Gerrit. I've just rebased and slightly cleaned up the if statement (use braces and removed "this.").

-------------------------------------
author: Brenden Conley
date: 2016-12-01 13:59:51.000000000

Patch Set 10:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/11378/

-------------------------------------
author: Brenden Conley
date: 2016-12-01 15:01:01.000000000

Patch Set 10: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/11378/ : SUCCESS

-------------------------------------
author: Anthony Pineda
date: 2016-12-01 15:02:44.000000000

Patch Set 10:

Thanks for the help and the review Brian and Andrey.

-------------------------------------
author: Gerrit Code Review
date: 2016-12-01 15:06:15.000000000

Change has been successfully merged into the git repository by Jayvion Booth

-------------------------------------
