DESCRIPTION

Bug 507404 - TrimBarLayout´s computeSize method may cause NPE due to
missing MTrimBar

Now the code is now more defensive as in case of missing MTrimBar there
will be no NPE. 

Change-Id: Icf0dd3a1955968bfa4869aad2420da37d564963b
Signed-off-by: Ryker Bauer xxx@xxx.xxx

COMMENTS

author: Ryker Bauer
date: 2016-11-13 16:22:16.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2016-11-13 16:22:22.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/11191/

-------------------------------------
author: Ryker Bauer
date: 2016-11-13 16:25:25.000000000

Patch Set 1:

Nevaeh Wu, hope you don't mind reviewing this. It should be a very quick review. Please, let me know what you think about this change.

-------------------------------------
author: Brenden Conley
date: 2016-11-13 16:51:24.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/11191/ : SUCCESS

-------------------------------------
author: Krista Shepherd
date: 2016-11-13 21:17:45.000000000

Patch Set 1:

(1 comment)

Hi Patrik.
I already had a similar patch, but had issues with the internet connection. So thanks for providing this.
Please see my inline comment.

Line:124, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/TrimBarLayout.java -> This looks even nicer:
if (bar instanceof MTrimBar) {
((MTrimBar) bar).getChildren().forEach(this::hideManagedTB);
}

Do you agree?

-------------------------------------
author: Ryker Bauer
date: 2016-11-13 22:38:59.000000000

Patch Set 1:

(1 comment)

Line:124, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/TrimBarLayout.java -> Yes, I like the idea. I'll implement it shortly. I think I should add you into the Signed-off-by field.

-------------------------------------
author: Gerrit Code Review
date: 2016-11-14 09:09:25.000000000

Change has been successfully merged into the git repository by Ryker Bauer

-------------------------------------
