DESCRIPTION

Bug 507103 - Reduce memory footprint of URLImageDescriptor

Change-Id: I7dc4290af0c40fae4ce95a411fafeeaba3e76e38
Signed-off-by: Myah Faulkner xxx@xxx.xxx

COMMENTS

author: Myah Faulkner
date: 2016-11-05 18:46:36.000000000

Uploaded patch set 4.

-------------------------------------
author: Brenden Conley
date: 2016-11-05 18:46:42.000000000

Patch Set 4:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/11137/

-------------------------------------
author: Brenden Conley
date: 2016-11-05 19:16:24.000000000

Patch Set 4: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/11137/ : SUCCESS

-------------------------------------
author: Jayvion Booth
date: 2016-11-05 19:18:00.000000000

Patch Set 4:

(1 comment)

Sorry Dirk, one more question.

Line:156, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/menus/MenuHelper.java -> How we can have older jface version running? Shouldn't we just make the version constraints in the MANIFEST.MF to the expected JFace version?

-------------------------------------
author: Myah Faulkner
date: 2016-11-05 19:48:31.000000000

Patch Set 4:

(1 comment)

Line:156, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/menus/MenuHelper.java -> The change in URLImageDescriptor does not increase the minor version of the JFace bundle. It is an internal change and we are accessing the field here via reflection. So I don't think we can define the dependency in the MANIFEST. IMHO we should not restrict dependencies on bugfix versions because of internal changes.

-------------------------------------
author: Jayvion Booth
date: 2016-11-05 21:19:13.000000000

Patch Set 4:

(1 comment)

Line:156, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/menus/MenuHelper.java -> OK. BTW, we can replace the instanceof URL check with null check (paranoia) and just return value.toString(). URL.toString() returns toExternalForm() anyway.

-------------------------------------
author: Gerrit Code Review
date: 2016-11-07 09:33:16.000000000

Change has been successfully merged into the git repository by Myah Faulkner

-------------------------------------
