DESCRIPTION

Bug 507103 - Reduce memory footprint of URLImageDescriptor

Change-Id: I7dc4290af0c40fae4ce95a411fafeeaba3e76e38
Signed-off-by: Myah Faulkner xxx@xxx.xxx

COMMENTS

author: Myah Faulkner
date: 2016-11-05 15:20:19.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2016-11-05 15:20:25.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/11134/

-------------------------------------
author: Brenden Conley
date: 2016-11-05 15:52:11.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/11134/ : SUCCESS

-------------------------------------
author: Jayvion Booth
date: 2016-11-05 16:12:20.000000000

Patch Set 1:

(2 comments)

Line:150, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/menus/MenuHelper.java -> I wonder why is this not ImageDescriptor class, but just "?"

Line:158, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/menus/MenuHelper.java -> If we are touching this mess, can we at least make it a little bit nicer? Please, throw here an exception so that if it breaks we will know it from the test and not from the users.

-------------------------------------
author: Myah Faulkner
date: 2016-11-05 18:43:01.000000000

Patch Set 1:

> > (2 comments)
 > 
 > Dirk, what about my first commentson MenuHelper?

haven't seen them :(

-------------------------------------
author: Gerrit Code Review
date: 2016-11-07 09:33:16.000000000

Change has been successfully merged into the git repository by Myah Faulkner

-------------------------------------
