DESCRIPTION

Bug 490139 - Fix hashCode and equals in databinding classes

Change-Id: I036d24149f7bce9569c0d11515fe17b9c298c525
Signed-off-by: Yusuf Hays xxx@xxx.xxx


COMMENTS

author: Isis Velasquez
date: 2017-08-23 14:48:41.000000000

Patch Set 3: Patch Set 2 was rebased

-------------------------------------
author: Brenden Conley
date: 2017-08-23 14:48:49.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/13383/

-------------------------------------
author: Brenden Conley
date: 2017-08-23 14:58:20.000000000

Patch Set 3: Verified-1

Build Failed 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/13383/ : FAILURE

-------------------------------------
author: Isis Velasquez
date: 2017-08-31 19:28:55.000000000

Patch Set 3: Code-Review-1

(6 comments)

If we're sure that hashCode and equals shouldn't be overriden here, what about overriding them to mark them final in the Abstract* classes?

It might be a breaking API change though. But maybe the PMC can evaluate it as low-risk and allow such change if it prevents bugs from happening.

Line:60, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/Observables.java -> Is this related to the equals/hashCode change?

Line:97, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/value/WritableValue.java -> can `value` be null? if not `value.equals(this.value)`

Line:208, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/value/SelectObservableValue.java -> How does this relate to the equals/hashCode issue?
If not, please make a separate commit for it.

Line:211, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/value/SelectObservableValue.java -> What's the value with this intermediary variable?

Line:212, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/value/SelectObservableValue.java -> Can `observable` be null? If not, it could simply be `observable.equals(observableValue)`

Line:146, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/map/BidiObservableMap.java -> Can `key` be null? If not, key.equals(element)

-------------------------------------
