DESCRIPTION

Bug 506120 - prevent NPE if CSS styling is disabled

Change-Id: I3bce02bc954a0be73c9e14bbf65536de612f8f89
Signed-off-by: Konner Mcintyre xxx@xxx.xxx


COMMENTS

author: Konner Mcintyre
date: 2016-10-18 07:14:14.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2016-10-18 07:14:20.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/10969/

-------------------------------------
author: Brenden Conley
date: 2016-10-18 07:46:00.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/10969/ : SUCCESS

-------------------------------------
author: Krista Shepherd
date: 2016-10-18 08:19:28.000000000

Patch Set 1: Code-Review+1

(1 comment)

Thanks for the patch.
Please see my inline comment.

Line:884, bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/impl/engine/AbstractCSSEngine.java -> Why not moving this at the very beginning of this mehtod? IHMO having the elt variable is not necessary here.

-------------------------------------
author: Jayvion Booth
date: 2016-12-01 09:06:58.000000000

Patch Set 1: Code-Review-1

I've answered on bug.

-------------------------------------
author: Gerrit Code Review
date: 2016-12-05 10:42:20.000000000

Change has been successfully merged into the git repository by Jayvion Booth

-------------------------------------
