DESCRIPTION

Bug 505738 - Define a Documentation hover color which JDT, CDT or others
can use

Now defines a color factor as Leo (I think) wants. Patch needs
validation on all platforms

Change-Id: I4d0adddf4ff11c814562f4b2100243703c0659b9
Signed-off-by: Zaid Mosley xxx@xxx.xxx

COMMENTS

author: Brenden Conley
date: 2016-10-14 19:52:27.000000000

Patch Set 8:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/10942/

-------------------------------------
author: Brock Pruitt
date: 2016-10-14 20:09:27.000000000

Patch Set 8:

(5 comments)

Line:10, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/themes/DocumentationHoverColorFactory.java -> Unnecessary blank line.

Line:23, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/themes/DocumentationHoverColorFactory.java -> Unnecessary blank line.

Line:28, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/themes/DocumentationHoverColorFactory.java -> Inconsistent use of curly braces.

Line:28, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/themes/DocumentationHoverColorFactory.java -> Indentation is off

Line:36, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/themes/DocumentationHoverColorFactory.java -> Unnecessary blank lines.

-------------------------------------
author: Brenden Conley
date: 2016-10-14 20:24:33.000000000

Patch Set 8: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/10942/ : SUCCESS

-------------------------------------
author: Natalia Golden
date: 2016-10-14 20:26:10.000000000

Patch Set 8:

> (5 comments)

I think this is more of a proof-of-concept. I'm currently working on a version that supports both foreground and background. I'll also test it against javadoc hover. ~Patch in progress.

-------------------------------------
author: Natalia Golden
date: 2016-10-14 21:20:46.000000000

Patch Set 8:

> > May I add the functionality?
 > 
 > Sure. I think you cannot ammend my commit, but please add a commit
 > on top of mine. 

Yea, as non-contributor I could only submit a new patch:
https://git.eclipse.org/r/#/c/83274

 > I could merge both after my vacation of the next
 > week. See you in Ludwigsburg?

Gute Reise.

-------------------------------------
author: Zaid Mosley
date: 2016-11-01 10:32:12.000000000

Abandoned

Leos commit will solve that better https://git.eclipse.org/r/#/c/83274

-------------------------------------
