DESCRIPTION

Bug 160802: [Markers] Problems View, Errors: must copy whole line

- patch adds Copy Details submenu with additional commands (inspired by
similar use case in Mylyn, consistent naming)
- submenu contains "Description" and "Qualified Name" (inspired by JDT)
items for copying these information into clipboard
- patch intentionally do not put menu item for each possible attribute
as it would be too much and not usefull (just most usefull ones)
- main "copy" item remain unchanged - for generating tab-separated
report of all visible information as until now
- patch works for different kinds of markers (errors, warnings in
"Problems View" or tasks in "Task View")
- fixes also similar bug 244965

Change-Id: I510d61ef7599992e769ca5cd4b33f7a5701d397a
Task-Url: https://bugs.eclipse.org/bugs/show_bug.cgi?id=106954
Signed-off-by: Kamryn Huynh xxx@xxx.xxx

COMMENTS

author: Kamryn Huynh
date: 2016-10-06 16:01:56.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2016-10-06 16:02:02.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/10842/

-------------------------------------
author: Brenden Conley
date: 2016-10-06 17:02:47.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/10842/ : SUCCESS

-------------------------------------
author: Zaid Mosley
date: 2016-10-07 12:43:21.000000000

Patch Set 1:

Cooool. Thanks for this contribution.

A few suggestions:

The column is called "Resource". I suggest to name the copy action also "Resource" instead of "Qualified Name".
Please remove the whitespace in the Javadoc.

Other than that, I think this is good to go.

-------------------------------------
author: Kamryn Huynh
date: 2016-10-07 18:42:52.000000000

Patch Set 1:

Regarding Qualified -> Resource - the menu item action is actually copying into clipboard full path of resource of the marker -> so i propose alternative - to name menu item "Copy Details > Resource Qualified Name" (still keeping "qualified name" term which is commonly used from JDT, but indicate it is from Resource column)
(follows adapted patch in this way, ...but if this variation would not be suitable i can in the end put just "Resource" label)
in patch is removed whitespce from javadoc of handlers(In reply to comment #2)
> Patch Set 1:
> 
> Cooool. Thanks for this contribution.
> 
> A few suggestions:
> 
> The column is called "Resource". I suggest to name the copy action also
> "Resource" instead of "Qualified Name".
> Please remove the whitespace in the Javadoc.
> 
> Other than that, I think this is good to go.

Regarding Qualified -> Resource - the menu item action is actually copying into clipboard full path of resource of the marker -> so i propose alternative - to name menu item "Copy Details > Resource Qualified Name" (still keeping "qualified name" term which is commonly used from JDT, but indicate it is from Resource column)
(follows adapted patch in this way, ...but if this variation would not be suitable i can in the end put just "Resource" label)
in patch is removed whitespce from javadoc of handlers

-------------------------------------
author: Gerrit Code Review
date: 2016-10-11 06:40:14.000000000

Change has been successfully merged into the git repository by Zaid Mosley

-------------------------------------
