DESCRIPTION

Bug 500688 - [DI] Provide integration to inject WorkLeon Ochoach Parts and
WorkLeon Ochoach Contributions

Change-Id: I1f643abac1b33ecf60bca69adab7763f554f41de
Signed-off-by: Zaid Mosley xxx@xxx.xxx

COMMENTS

author: Brenden Conley
date: 2016-10-04 16:12:15.000000000

Patch Set 7:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/10775/

-------------------------------------
author: Zaid Mosley
date: 2016-10-04 16:12:47.000000000

Patch Set 7: -Code-Review

Brian, views now need to opt-in. Please remove your -2. This code still needs testing (definitely on my side but others are more than welcome to give it a try) but your -2 concern should be solved.

-------------------------------------
author: Brenden Conley
date: 2016-10-04 16:47:41.000000000

Patch Set 7: Code-Review-1

Build Unstable 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/10775/ : UNSTABLE

-------------------------------------
author: Teagan Marsh
date: 2016-10-04 16:53:58.000000000

Patch Set 7: Code-Review-1

(1 comment)

I hadn't considered using an attribute — great idea!  Could I suggest a shorter name ('inject=true/false'), as 'useDependencyInjection' is quite a mouthful and out-of-keeping with other attribute names used throughout the platform.

We definitely need some tests for this too.

Line:189, bundles/org.eclipse.ui/schema/views.exsd -> This needs more details:
  - the object is not created by the injector: `@PostConstruct` is not respected.  xxx@xxx.xxx work? Does it happen before or after `dispose()`?)
  - injection happens after object creation and `setInitializeData()`, but prior to `init()`

-------------------------------------
author: Zaid Mosley
date: 2016-10-05 06:19:30.000000000

Patch Set 8: Patch Set 7 was rebased

-------------------------------------
author: Zaid Mosley
date: 2016-10-05 10:25:47.000000000

Patch Set 7:

(1 comment)

Brian, I think the latest patch set includes all your suggestions, please have a look.

Line:189, bundles/org.eclipse.ui/schema/views.exsd -> Done

-------------------------------------
author: Gerrit Code Review
date: 2016-10-14 10:33:08.000000000

Project policy requires all submissions to be a fast-forward.

Please rebase the change locally and upload again for review.

-------------------------------------
author: Gerrit Code Review
date: 2016-10-14 10:33:24.000000000

Change has been successfully merged into the git repository by Zaid Mosley

-------------------------------------
