DESCRIPTION

Bug 500688 - [DI] Provide integration to inject WorkLeon Ochoach Parts and
WorkLeon Ochoach Contributions

Suggestions from Brian included:

- Using inject as new attribute views.exsd
- Adds tests for part using DI
- Documents the order of method invocation
- Using * to mark additional steps
- Using <o> and <p> elements to structure the description
- Adds DependencyInjectionViewTest to the ApiTestSuite

Change-Id: I1f643abac1b33ecf60bca69adab7763f554f41de
Signed-off-by: Zaid Mosley xxx@xxx.xxx

COMMENTS

author: Brenden Conley
date: 2016-10-13 13:35:49.000000000

Patch Set 20:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/10921/

-------------------------------------
author: Brenden Conley
date: 2016-10-13 14:11:00.000000000

Patch Set 20: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/10921/ : SUCCESS

-------------------------------------
author: Teagan Marsh
date: 2016-10-13 16:58:22.000000000

Patch Set 20:

(2 comments)

> Brian, any more concerns except the reparenting issue? If not I
 > plan to merge it end of this week, after having tested the
 > reparenting.

I'm good; just a teeny tweak.  Thanks for tackling this!

Line:83, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/ContributedPartRenderer.java -> Lines 82-88 seem like they should be flattened into one block

Line:87, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/ContributedPartRenderer.java -> has -> have

-------------------------------------
author: Zaid Mosley
date: 2016-10-14 00:37:47.000000000

Patch Set 20: Code-Review+2 Verified+1

(2 comments)

Line:83, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/ContributedPartRenderer.java -> Done

Line:87, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/ContributedPartRenderer.java -> Done

-------------------------------------
author: Gerrit Code Review
date: 2016-10-14 10:33:08.000000000

Project policy requires all submissions to be a fast-forward.

Please rebase the change locally and upload again for review.

-------------------------------------
author: Gerrit Code Review
date: 2016-10-14 10:33:24.000000000

Change has been successfully merged into the git repository by Zaid Mosley

-------------------------------------
