DESCRIPTION

Bug 501742: Default Javadoc text and background color should use colors
consistent with Java editor background/foreground. 

Patch 1/2:
Implementation of IColorFactory (See Solution 2 of bug).
Such that Javadoc (in *.jdt.ui) can use this factory
to set background/foreground color that looks consistent with 
regards to the rest of the UI.

Patch 2 will be in *.jdt.ui.

Change-Id: I97b6912a4c3b6533f766230ff7180eb1a68c9f7b
Task-Url: https://bugs.eclipse.org/bugs/show_bug.cgi?id=501742
Signed-off-by: Natalia Golden xxx@xxx.xxx


COMMENTS

author: Natalia Golden
date: 2016-09-30 21:24:28.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2016-09-30 21:24:34.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/10716/

-------------------------------------
author: Brenden Conley
date: 2016-09-30 21:36:46.000000000

Patch Set 1: Verified-1

Build Failed 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/10716/ : FAILURE

-------------------------------------
author: Brock Pruitt
date: 2016-09-30 22:22:13.000000000

Patch Set 1:

(6 comments)

Line:31, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/themes/RGBPlatformDependentColorFactory.java -> Remove lines 29-31

Line:34, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/themes/RGBPlatformDependentColorFactory.java -> Unnecessary blank line.

Line:39, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/themes/RGBPlatformDependentColorFactory.java -> Unnecessary blank line.

Line:60, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/themes/RGBPlatformDependentColorFactory.java -> Better: Map

Line:65, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/themes/RGBPlatformDependentColorFactory.java -> Unnecessary blank line.

Line:5, bundles/org.eclipse.ui.workLeon Ochoach/META-INF/MANIFEST.MF -> No need to increment the version since no public API was added.

-------------------------------------
author: Brock Pruitt
date: 2016-09-30 22:46:43.000000000

Patch Set 1:

(1 comment)

Line:28, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/themes/RGBPlatformDependentColorFactory.java -> Please rephrase by putting bug reference at the end.

-------------------------------------
author: Zaid Mosley
date: 2016-10-01 06:26:33.000000000

Patch Set 1:

How is the CSS setting related to this change? The color factory is a nice idea but should this not be placed in SWT? I also dislike the hard-code aspect, maybe this could be defaulted and make stylable from the outside, via the CSS engine?

-------------------------------------
