DESCRIPTION

Bug 502841 - TreeViewer::expandAll() causes cursor to flicker

createChildren(), changes the cursor from arrow to hour-glass and back
while TreeItems are created. In some cases, like e.g. expandAll(), this
method is call frequently (here for all tree items) and causes unwanted
flicker.

Remove BusyIndicator.showWhile() that surrounds the item-creation code.
This leaves the application code to decide whether some busy indicator
is shown or not.

Change-Id: I42a7c6826a6e2afae54b8db2868576ffc54265ad
Signed-off-by: Brian Lynch xxx@xxx.xxx

COMMENTS

author: Brenden Conley
date: 2016-10-04 08:36:03.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/10749/

-------------------------------------
author: Zaid Mosley
date: 2016-10-04 08:53:52.000000000

Patch Set 3: Code-Review+2 Verified+1

Digging in the history of platform UI, the BusyIndicator.showWhile was added via Bug 154571. But as BusyIndicator.showWhile does not do any additional protection, e.g., like using a SafeRunnable, I think it is save to remove it.

I plan to merge this, but as Andrey also added himself to the review I wait a few more days to hear if Andrey see problems with the change.

Thanks Rüdiger.

-------------------------------------
author: Jayvion Booth
date: 2016-10-04 09:12:30.000000000

Patch Set 3: Code-Review-1

O've commented on the bug. In short, please check bug 6732.

-------------------------------------
author: Brenden Conley
date: 2016-10-04 09:13:04.000000000

Patch Set 3: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/10749/ : SUCCESS

-------------------------------------
author: Gerrit Code Review
date: 2017-01-31 14:45:13.000000000

Change has been successfully merged into the git repository by Zaid Mosley

-------------------------------------
