DESCRIPTION

Bug 501916 - Fix potential resource leak

Change-Id: I3dc1f6c459a483624207864dc8210b094cf820fd
Signed-off-by: Cash Galloway xxx@xxx.xxx

COMMENTS

author: Rayan Moreno
date: 2016-09-21 13:01:55.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2016-09-21 13:02:01.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/10533/

-------------------------------------
author: Zaid Mosley
date: 2016-09-21 13:49:24.000000000

Patch Set 1: Code-Review-1

(1 comment)

Line:369, bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/DialogSettings.java -> Why not try with resources here?

-------------------------------------
author: Rayan Moreno
date: 2016-09-21 14:02:05.000000000

Patch Set 1:

(1 comment)

Line:369, bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/DialogSettings.java -> The caller is responsible for closing the "writer". Here XMLWriter is just a wrapper and must not be close, otherwise it also closes "writer"

-------------------------------------
author: Brenden Conley
date: 2016-09-21 16:10:05.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/10533/ : SUCCESS

-------------------------------------
author: Gerrit Code Review
date: 2016-09-21 16:15:26.000000000

Change has been successfully merged into the git repository by Zaid Mosley

-------------------------------------
