DESCRIPTION

Bug 266030 - Allow "others" working set in Project Explorer

Change-Id: I787c070e3bd2733259709545111e3d010bda86bd
Signed-off-by: Isis Velasquez xxx@xxx.xxx


COMMENTS

author: Isis Velasquez
date: 2016-09-16 09:27:45.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2016-09-16 09:27:54.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/10415/

-------------------------------------
author: Brenden Conley
date: 2016-09-16 09:49:22.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/10415/ : SUCCESS

-------------------------------------
author: Teagan Marsh
date: 2016-09-22 13:58:16.000000000

Patch Set 1: Code-Review+1

(2 comments)

Thanks for tackling this Mickael and sorry for the delay in reviewing.  My only real comments:

I think we should align the text used to match the Package Explorer: so 'Other Projects', rather than 'Other'.

I think the different placement of Other, as compared to the Package Explorer, makes sense: the user has chosen to emphasize working sets, so projects that aren't in a working set are different.  But it's worth soliciting feedback from the users who strongly wanted this feature back.

I think we should *always* show other projects in the Other category.  The menu item to enable this ("…and show remaining projects in ") looks rather bizarre.  And I can't really think of a reason why you would to remove any other projects from view: the 'Other' is easy to ignore, and it helps to discover if there are projects that aren't included in other working sets (which happens to me periodically).

Line:28, bundles/org.eclipse.ui.navigator.resources/src/org/eclipse/ui/internal/navigator/workingsets/WorkingSetSorter.java -> Maybe a comment to note this ensures OTHERS is sorted to the end?

Line:163, bundles/org.eclipse.ui.navigator.resources/src/org/eclipse/ui/internal/navigator/workingsets/WorkingSetsContentProvider.java -> stray 't' in "not": "there's *no* content'

-------------------------------------
author: Gerrit Code Review
date: 2016-09-28 14:48:39.000000000

Change has been successfully merged into the git repository by Isis Velasquez

-------------------------------------
