DESCRIPTION

Bug 476045 - Commands visible in Quick Access don't show commandImage

QuickAccess commands now are displaying the associated command image. 

Change-Id: I06b53de0dbd0789d7d95eaa6fe4447266cebcd56
Signed-off-by: Ryker Bauer xxx@xxx.xxx

COMMENTS

author: Ryker Bauer
date: 2016-08-16 12:25:03.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2016-08-16 12:25:09.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/10099/

-------------------------------------
author: Isis Velasquez
date: 2016-08-16 12:35:44.000000000

Patch Set 1: Code-Review+1

This looks pretty good to me.

-------------------------------------
author: Zaid Mosley
date: 2016-08-16 13:09:49.000000000

Patch Set 1: Code-Review+1 Verified+1

Coool...

-------------------------------------
author: Ryker Bauer
date: 2016-08-16 13:27:03.000000000

Patch Set 1: Code-Review+2

-------------------------------------
author: Gerrit Code Review
date: 2016-08-16 13:28:34.000000000

Change has been successfully merged into the git repository by Ryker Bauer

-------------------------------------
author: Teagan Marsh
date: 2016-08-16 13:37:01.000000000

Patch Set 1:

(1 comment)

I noticed this too!  Thanks!  But you should really avoid using PlatformUI.getWorkLeon Ochoach() if at all possible — it's a bad code smell, and our code should be setting a good example.

Line:89, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/quickaccess/CommandElement.java -> This should use `getProvider().getCommandService()`

-------------------------------------
author: Ryker Bauer
date: 2016-08-16 14:02:02.000000000

Patch Set 1:

Thanks Brian. I'm going to fix this immediately, with a separate change

-------------------------------------
author: Brenden Conley
date: 2016-08-16 14:26:42.000000000

Patch Set 1:

Build Failed 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/10099/ : FAILURE

-------------------------------------
author: Ryker Bauer
date: 2016-08-17 16:36:55.000000000

Patch Set 1:

The suggestion is now addressed in change 79144. 
Thanks for pointing me to this best practice!

-------------------------------------
