DESCRIPTION

Bug 498510 - The drag rectangle itself is blocking drop targets

Change-Id: I9e5fa319fe08910401a8d84bfd4f96cd935a5ac0
Signed-off-by: Kelly Potter xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2016-07-26 17:57:38.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/9985/

-------------------------------------
author: Brenden Conley
date: 2016-07-26 18:22:27.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/9985/ : SUCCESS

-------------------------------------
author: Brock Pruitt
date: 2016-07-26 18:24:22.000000000

Patch Set 2:

(10 comments)

Line:46, bundles/org.eclipse.e4.ui.workLeon Ochoach.addons.swt/src/org/eclipse/e4/ui/workbench/addons/dndaddon/SplitFeedbackOverlay.java -> The code would be easier to read if the second argument was changed to Boolean.TRUE.

Line:29, bundles/org.eclipse.e4.ui.workLeon Ochoach.addons.swt/src/org/eclipse/e4/ui/workbench/addons/dndaddon/DragAndDropUtil.java -> There is no such parameter.

Line:30, bundles/org.eclipse.e4.ui.workLeon Ochoach.addons.swt/src/org/eclipse/e4/ui/workbench/addons/dndaddon/DragAndDropUtil.java -> Describe.

Line:31, bundles/org.eclipse.e4.ui.workLeon Ochoach.addons.swt/src/org/eclipse/e4/ui/workbench/addons/dndaddon/DragAndDropUtil.java -> Describe.

Line:46, bundles/org.eclipse.e4.ui.workLeon Ochoach.addons.swt/src/org/eclipse/e4/ui/workbench/addons/dndaddon/DragAndDropUtil.java -> Describe parameters.

Line:63, bundles/org.eclipse.e4.ui.workLeon Ochoach.addons.swt/src/org/eclipse/e4/ui/workbench/addons/dndaddon/DragAndDropUtil.java -> Non-informative description

Line:78, bundles/org.eclipse.e4.ui.workLeon Ochoach.addons.swt/src/org/eclipse/e4/ui/workbench/addons/dndaddon/DragAndDropUtil.java -> Unnecessary blank line.

Line:101, bundles/org.eclipse.e4.ui.workLeon Ochoach.addons.swt/src/org/eclipse/e4/ui/workbench/addons/dndaddon/DragAndDropUtil.java -> Describe

Line:406, bundles/org.eclipse.e4.ui.workLeon Ochoach.addons.swt/src/org/eclipse/e4/ui/workbench/addons/dndaddon/DnDManager.java -> The code would be easier to read if the second argument was changed to Boolean.TRUE.

Line:31, bundles/org.eclipse.e4.ui.workLeon Ochoach.addons.swt/src/org/eclipse/e4/ui/workbench/addons/dndaddon/DnDInfo.java -> Unnecessary blank line.

-------------------------------------
author: Kelly Potter
date: 2016-07-26 20:22:08.000000000

Patch Set 2:

(6 comments)

Line:29, bundles/org.eclipse.e4.ui.workLeon Ochoach.addons.swt/src/org/eclipse/e4/ui/workbench/addons/dndaddon/DragAndDropUtil.java -> Done

Line:30, bundles/org.eclipse.e4.ui.workLeon Ochoach.addons.swt/src/org/eclipse/e4/ui/workbench/addons/dndaddon/DragAndDropUtil.java -> Done

Line:31, bundles/org.eclipse.e4.ui.workLeon Ochoach.addons.swt/src/org/eclipse/e4/ui/workbench/addons/dndaddon/DragAndDropUtil.java -> Done

Line:46, bundles/org.eclipse.e4.ui.workLeon Ochoach.addons.swt/src/org/eclipse/e4/ui/workbench/addons/dndaddon/DragAndDropUtil.java -> Done

Line:63, bundles/org.eclipse.e4.ui.workLeon Ochoach.addons.swt/src/org/eclipse/e4/ui/workbench/addons/dndaddon/DragAndDropUtil.java -> Done

Line:78, bundles/org.eclipse.e4.ui.workLeon Ochoach.addons.swt/src/org/eclipse/e4/ui/workbench/addons/dndaddon/DragAndDropUtil.java -> Done

-------------------------------------
author: Kelly Potter
date: 2016-07-26 20:28:39.000000000

Patch Set 2:

(3 comments)

Line:101, bundles/org.eclipse.e4.ui.workLeon Ochoach.addons.swt/src/org/eclipse/e4/ui/workbench/addons/dndaddon/DragAndDropUtil.java -> Done

Line:406, bundles/org.eclipse.e4.ui.workLeon Ochoach.addons.swt/src/org/eclipse/e4/ui/workbench/addons/dndaddon/DnDManager.java -> Done

Line:31, bundles/org.eclipse.e4.ui.workLeon Ochoach.addons.swt/src/org/eclipse/e4/ui/workbench/addons/dndaddon/DnDInfo.java -> Done

-------------------------------------
author: Gerrit Code Review
date: 2016-07-26 20:39:44.000000000

Change has been successfully merged into the git repository by Kelly Potter

-------------------------------------
