DESCRIPTION

Bug 211427
Check if a file exists but cannot be read due to file permissions. Avoid
logging of exception with stack trace in such case. Show specific error
message.

Change-Id: I6e632c4836b8b6c4be1cfd16f5cd78d3ef3d5599
Signed-off-by: Porter Chapman xxx@xxx.xxx

COMMENTS

author: Brenden Conley
date: 2016-07-21 19:51:47.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/9968/

-------------------------------------
author: Brenden Conley
date: 2016-07-21 20:14:41.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/9968/ : SUCCESS

-------------------------------------
author: Jayvion Booth
date: 2016-07-22 08:48:42.000000000

Patch Set 2: Code-Review-1

(3 comments)

Line:598, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/wizards/datatransfer/ImportOperation.java -> can we follow conventions and name it hasNoReadPermissions()

Line:599, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/wizards/datatransfer/ImportOperation.java -> can we invert the condition and return early, to avoid deep nesting below?

Line:614, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/wizards/datatransfer/ImportOperation.java -> Why not just use Files.isRegularFile here?
And why do we need it at all if the Files.isReadable already asks for permissions?

-------------------------------------
author: Zaid Mosley
date: 2016-08-17 11:07:55.000000000

Patch Set 2:

Hauke, any plans to provide an update?

-------------------------------------
author: Isis Velasquez
date: 2016-09-07 09:02:41.000000000

Patch Set 2:

Hauke, can you please update your patch according to Andrey's comment? If necessary, we'd be glad to provide you assistance on the best way to update and push it.

-------------------------------------
