DESCRIPTION

Bug 473973 - NullPointerException in InternalDialog.refreshDialogSize
(392) 

Added fast-fail guard against getShell()==null, in
InternalDialog#refreshDialogSize()

Change-Id: I1eb5a0693c9ed28c9af504fffdccc037ccc9d79a
Signed-off-by: Ryker Bauer xxx@xxx.xxx

COMMENTS

author: Ryker Bauer
date: 2016-06-30 15:54:53.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2016-06-30 15:54:59.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/9729/

-------------------------------------
author: Brenden Conley
date: 2016-06-30 16:10:01.000000000

Patch Set 1: Verified-1

Build Failed 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/9729/ : FAILURE

-------------------------------------
author: Jayvion Booth
date: 2016-07-01 09:52:06.000000000

Patch Set 1:

(1 comment)

Line:373, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/statushandlers/InternalDialog.java -> It is OK, but to be consistent with the refresh() I would use this code:
if (dialogArea == null || dialogArea.isDisposed()) {
    return;
}

-------------------------------------
author: Jayvion Booth
date: 2016-07-01 09:52:12.000000000

Patch Set 2: Patch Set 1 was rebased

-------------------------------------
author: Ryker Bauer
date: 2016-07-01 10:44:46.000000000

Patch Set 1:

(1 comment)

Line:373, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/statushandlers/InternalDialog.java -> Yes, it totally makes sense

-------------------------------------
author: Gerrit Code Review
date: 2016-07-01 11:55:08.000000000

Change has been successfully merged into the git repository by Ryker Bauer

-------------------------------------
