DESCRIPTION

Bug 496270 - Fix potential NPE in ModelServiceImpl#getPartDescriptor

Change-Id: Ic9cfa2afafc13c859e91e4bbea86aceed8f8a5c0
Signed-off-by: Zaid Mosley xxx@xxx.xxx

COMMENTS

author: Zaid Mosley
date: 2016-06-16 20:09:32.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2016-06-16 20:09:38.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/9605/

-------------------------------------
author: Brenden Conley
date: 2016-06-16 20:31:17.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/9605/ : SUCCESS

-------------------------------------
author: Mariela Flores
date: 2016-06-17 06:49:36.000000000

Patch Set 1:

(1 comment)

Line:1038, bundles/org.eclipse.e4.ui.workLeon Ochoach/src/org/eclipse/e4/ui/internal/workbench/ModelServiceImpl.java -> You should:
a) move the null check above the id == null ?
b) the you can remove the id == null ? because you know for sure it can not be null
c) you can rewrite the 
   String descId = colonIndex == -1 ? id : id.substring(0, colonIndex);

   to

   String descId = id.indexOf(':') == -1 ? id : id.substring(0, colonIndex);

-------------------------------------
