DESCRIPTION

Bug 493552 - Notification about going to full screen is shown on wrong
monitor

Use the parent shell's monitor bounds as an indication of where to place
the new pop-up shell, instead of the just-created popup shell.

Change-Id: I3438bbdd8c0c536d3ea583cd52fbb0b58cc739fb
Signed-off-by: Alivia Ritter xxx@xxx.xxx


COMMENTS

author: Kaeden Tapia
date: 2016-05-31 05:39:51.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2016-05-31 05:39:57.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/9490/

-------------------------------------
author: Brenden Conley
date: 2016-05-31 05:58:00.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/9490/ : SUCCESS

-------------------------------------
author: Teagan Marsh
date: 2016-05-31 14:10:54.000000000

Patch Set 1:

(1 comment)

Looks good to me, modulo a null check.

Line:108, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/handlers/FullScreenHandler.java -> For safety, should check the parent and call super.getInitialLocation() if null.  The handler does a HandlerUtil#getActiveShell() rather than #getActiveShellChecked().

-------------------------------------
author: Kaeden Tapia
date: 2016-05-31 15:19:34.000000000

Patch Set 1:

(1 comment)

Line:108, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/handlers/FullScreenHandler.java -> Done

-------------------------------------
author: Gerrit Code Review
date: 2016-06-01 14:10:23.000000000

Change has been successfully merged into the git repository by Teagan Marsh

-------------------------------------
