DESCRIPTION

Bug 492733 - Open Projects wizard scanning not cancelable

Improve progress reporting

Change-Id: I9f276c7f5ff14a56dc7cfccb2bdc8fa33567f602
Signed-off-by: Isis Velasquez xxx@xxx.xxx


COMMENTS

author: Isis Velasquez
date: 2016-05-04 14:31:02.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2016-05-04 14:31:07.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/9343/

-------------------------------------
author: Brenden Conley
date: 2016-05-04 14:50:15.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/9343/ : SUCCESS

-------------------------------------
author: Brock Pruitt
date: 2016-05-05 17:10:27.000000000

Patch Set 1:

(7 comments)

Line:173, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/wizards/datatransfer/SmartImportJob.java -> Better to combine with the convert call by using the three-parameter variant.

Line:173, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/wizards/datatransfer/SmartImportJob.java -> The second parameter of this call overrides the second parameter of the convert call in the previous line.

Line:372, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/wizards/datatransfer/SmartImportJob.java -> Simpler:
SubMonitor subMonitor = SubMonitor.convert(progressMonitor, NLS.bind(DataTransferMessages.SmartImportJob_inspecting,				container.getLocation().toFile().getAbsolutePath()), allWork);

Line:433, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/wizards/datatransfer/SmartImportJob.java -> Better to use split() instead of worked() since it checks for cancellation. The split call can be moved outside of the 'if' statement.

Line:472, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/wizards/datatransfer/SmartImportJob.java -> Better to split the line after (

Line:502, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/wizards/datatransfer/SmartImportJob.java -> Combine with convert.

Line:508, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/wizards/datatransfer/SmartImportJob.java -> Better to use subMonitor.setWorkRemaining(1) after the 'if' statement. This would result in smoother progress.

-------------------------------------
author: Gerrit Code Review
date: 2016-05-06 17:34:01.000000000

Change has been successfully merged into the git repository by Isis Velasquez

-------------------------------------
