DESCRIPTION

Bug 461266 - Nested project is not updated on project deletion

Change-Id: I70bd46016ceaf75b87abe5b6ecf8c50eb994a26a
Signed-off-by: Isis Velasquez xxx@xxx.xxx


COMMENTS

author: Isis Velasquez
date: 2016-05-03 08:37:56.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2016-05-03 08:38:02.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/9320/

-------------------------------------
author: Brenden Conley
date: 2016-05-03 09:00:01.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/9320/ : SUCCESS

-------------------------------------
author: Jayvion Booth
date: 2016-05-03 13:00:16.000000000

Patch Set 1:

(3 comments)

Line:59, bundles/org.eclipse.ui.navigator.resources/src/org/eclipse/ui/internal/navigator/resources/nested/NestedProjectManager.java -> getDelta() can be null

Line:105, bundles/org.eclipse.ui.navigator.resources/src/org/eclipse/ui/internal/navigator/resources/nested/NestedProjectsContentProvider.java -> can be null too

Line:113, bundles/org.eclipse.ui.navigator.resources/src/org/eclipse/ui/internal/navigator/resources/nested/NestedProjectsContentProvider.java -> I would ask Sergey P. if this is all NPE safe or not. For me this looks really dangerous, but I'm old and have paranoia.

-------------------------------------
author: Brock Pruitt
date: 2016-05-03 17:56:02.000000000

Patch Set 1:

(1 comment)

Line:113, bundles/org.eclipse.ui.navigator.resources/src/org/eclipse/ui/internal/navigator/resources/nested/NestedProjectsContentProvider.java -> I would take any Javadoc mentioning possibility of null return seriously.  Consequences of not doing that can be really bad.

-------------------------------------
author: Gerrit Code Review
date: 2016-05-10 08:07:44.000000000

Change has been successfully merged into the git repository by Jayvion Booth

-------------------------------------
