DESCRIPTION

Bug 492401 : Autosave preference page must render "Note:" as bold

Change-Id: Ib602b454883f43295868d0e2f976f76d941cbd8a
Signed-off-by: Karter Mora xxx@xxx.xxx

COMMENTS

author: Rylee Bush
date: 2016-05-02 09:52:58.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2016-05-02 09:53:04.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/9307/

-------------------------------------
author: Brenden Conley
date: 2016-05-02 10:10:55.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/9307/ : SUCCESS

-------------------------------------
author: Isis Velasquez
date: 2016-05-03 11:17:00.000000000

Patch Set 1: Code-Review-1

(2 comments)

Some minor code concerns.

Line:93, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/AutoSavePreferencePage.java -> Please remove such debug/log lines.

Line:383, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/AutoSavePreferencePage.java -> Isn't this bug supposed to be fixed?

-------------------------------------
author: Sebastian Porter
date: 2016-05-03 12:47:50.000000000

Patch Set 1: Code-Review-2

This is the wrong approach.

Please use PreferencePage.createNoteComposite(Font, Composite, String, String)

-------------------------------------
author: Rylee Bush
date: 2016-05-04 07:36:34.000000000

Patch Set 1:

(2 comments)

Line:93, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/AutoSavePreferencePage.java -> Done

Line:383, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/AutoSavePreferencePage.java -> If you read comments from #c15, you will see that a problem still exists with MacOS.

-------------------------------------
author: Rylee Bush
date: 2016-05-04 07:39:36.000000000

Patch Set 1:

> This is the wrong approach.
 > 
 > Please use PreferencePage.createNoteComposite(Font, Composite,
 > String, String)

Dani, I think this is the good approach. The PreferencePage.createNoteComposite doesn't allow to set the appropriate layout data for the message. Furthermore, it exists a gap between the note part and the message part, causes by the bold style. With my approach the gap doesn't exists anymore.

-------------------------------------
author: Gerrit Code Review
date: 2016-05-10 08:45:58.000000000

Change has been successfully merged into the git repository by Sebastian Porter

-------------------------------------
