DESCRIPTION

Bug 491785 - Update popup of full screen mode to allow user to hide this
dialog

Popup how shows the actual keyb. shortcut, and adds "Do not show again"
checkbox.

Change-Id: I6423a8c5eaf82eb7000437de5b882855b69935d1
Signed-off-by: Ryker Bauer xxx@xxx.xxx

COMMENTS

author: Brenden Conley
date: 2016-04-19 19:08:38.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/9181/

-------------------------------------
author: Zaid Mosley
date: 2016-04-19 19:14:24.000000000

Patch Set 3: Code-Review+2 Verified+1

Looks good to me. I'm a little bit unsure if we must provide a way for the user to undo his selection.

-------------------------------------
author: Zaid Mosley
date: 2016-04-19 19:14:56.000000000

Patch Set 3:

Brian, what is your option. Must we provide a way via the preference to undo the user selection?

-------------------------------------
author: Brenden Conley
date: 2016-04-19 19:32:47.000000000

Patch Set 3: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/9181/ : SUCCESS

-------------------------------------
author: Teagan Marsh
date: 2016-04-20 01:53:04.000000000

Patch Set 3:

> Brian, what is your option. Must we provide a way via the
 > preference to undo the user selection?

Sorry, but I'm not clear what you're referring to.

If you mean a preference to disengage from full screen, given what you described for GTK (that the menu cannot be accessed in full-screen mode), then something would seem necessary for those users who do not have a keybinding.  An alternative would be to refuse to engage full-screen mode without a keybinding — perhaps just on those platforms without proper menu support when in full-screen?

If you mean the preference to never show the prompt?  I'd say yes, if we have a prompt that is blocking on the user input, as seems is currently the case.  Full-screen mode has been available in OS X for a while and from what I've read, users who use full-screen mode frequently switch in and out of full-screen mode.  It seems likely usage on other platforms will be similar.  For these users, the prompt will become a friction point.  The prompt is only needed for two reasons: (1) to educate new adopters as to how it works, and (2) to rescue users who inadvertently invoked it.  Once you're used to it, you'll never want to see a prompt again.

Now if the prompt was time-based instead, showing a message for a fixed time before self-destructing (300ms?), then perhaps a preference might not matter so much.  On OS X, these are called 'HUD' panels: translucent centred panels that disappear automatically.  Here's an example: http://www.raywenderlich.com/wp-content/uploads/2011/09/ProgressHUD.jpg  Such a HUD would reduce the friction, since the user wouldn't have to do an action, and they're already having to pause for the resize/relayout to occur.

-------------------------------------
author: Zaid Mosley
date: 2016-04-20 05:38:46.000000000

Patch Set 3:

Thanks Brian. With this change we have a check box "Never show this again". From your explanation I understand that it is OK to have this option without the need to allow to reverse that decision via the preference dialog.

-------------------------------------
author: Gerrit Code Review
date: 2016-04-20 05:38:54.000000000

Change has been successfully merged into the git repository by Zaid Mosley

-------------------------------------
