DESCRIPTION

Bug 496795 - implement real hasAtrribute for WidgetElement and sub
classes

Change-Id: I97c22b818d2718530123d865d632873f0ae5809c
Signed-off-by: Bradley Booth <Emma xxx@xxx.xxx


COMMENTS

author: Bradley Booth
date: 2016-06-27 19:53:48.000000000

Uploaded patch set 8.

-------------------------------------
author: Brenden Conley
date: 2016-06-27 19:53:54.000000000

Patch Set 8:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/9666/

-------------------------------------
author: Brenden Conley
date: 2016-06-27 20:16:14.000000000

Patch Set 8: Code-Review-1

Build Unstable 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/9666/ : UNSTABLE

-------------------------------------
author: Brenden Conley
date: 2016-06-28 07:22:32.000000000

Patch Set 8: -Code-Review

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/9670/

-------------------------------------
author: Brenden Conley
date: 2016-06-28 07:49:40.000000000

Patch Set 8: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/9670/ : SUCCESS

-------------------------------------
author: Jayvion Booth
date: 2016-06-30 08:15:31.000000000

Patch Set 8: Code-Review-1

(7 comments)

File Comment: tests/org.eclipse.e4.ui.tests.css.swt/src/org/eclipse/e4/ui/tests/css/swt/CSSSWTWidgetTest.java -> I would wish me the test cases with overridden protected fields set to null, see my comments in previous files.

Line:48, bundles/org.eclipse.e4.ui.css.swt/src/org/eclipse/e4/ui/css/swt/dom/html/SWTHTMLElement.java -> This is unsafe, since attributeType is protected and can be set to null, but the contract is to return supplier only on non null values.

This must be rewritten to check for the null value first.

Line:200, bundles/org.eclipse.e4.ui.css.swt/src/org/eclipse/e4/ui/css/swt/dom/WidgetElement.java -> We should add Assert.isNotNull() check here, to make sure that the new contract between hasAttribute and getAttribute is not broken unintentionally.

Line:215, bundles/org.eclipse.e4.ui.css.swt/src/org/eclipse/e4/ui/css/swt/dom/WidgetElement.java -> comma missing

Line:221, bundles/org.eclipse.e4.ui.css.swt/src/org/eclipse/e4/ui/css/swt/dom/WidgetElement.java -> dot missing

Line:227, bundles/org.eclipse.e4.ui.css.swt/src/org/eclipse/e4/ui/css/swt/dom/WidgetElement.java -> xxx@xxx.xxx null}

Line:234, bundles/org.eclipse.e4.ui.css.swt/src/org/eclipse/e4/ui/css/swt/dom/WidgetElement.java -> This is unsafe, since swtStyles is protected and can be set to null, but the contract is to return supplier only on non null values.

This must be rewritten to check for the null value first.

-------------------------------------
author: Gerrit Code Review
date: 2016-07-21 15:24:00.000000000

Change has been successfully merged into the git repository by Jayvion Booth

-------------------------------------
