DESCRIPTION

Bug 491312 - [Quick Access] Add shortcut to message of Quick Access Box in the toolbar

The Quick Access now displays the real shourtcut, and updates as
keybindings change

Originally Change-Id: I90ccd6e140c4b015b4fb8730c2be7c2f4979506b

Signed-off-by: Ryker Bauer xxx@xxx.xxx
Change-Id: I2b792a7e5ca526529f4e92608bbab4876fa01414


COMMENTS

author: Brenden Conley
date: 2016-04-15 06:59:47.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/9135/

-------------------------------------
author: Zaid Mosley
date: 2016-04-15 07:01:25.000000000

Patch Set 2:

This change gives me a widget is disposed exception and does not show the shortcut under Linux

org.eclipse.swt.SWTException: Widget is disposed
	at org.eclipse.swt.SWT.error(SWT.java:4533)
	at org.eclipse.swt.SWT.error(SWT.java:4448)
	at org.eclipse.swt.SWT.error(SWT.java:4419)
	at org.eclipse.swt.widgets.Widget.error(Widget.java:483)
	at org.eclipse.swt.widgets.Widget.checkWidget(Widget.java:420)
	at org.eclipse.swt.widgets.Control.getShell(Control.java:3057)
	at org.eclipse.swt.widgets.Control.requestLayout(Control.java:3880)
	at org.eclipse.ui.internal.quickaccess.SearchField.updateKeyBindingText(SearchField.java:333)
	at org.eclipse.ui.internal.quickaccess.SearchField.lambda$0(SearchField.java:144)
	at org.eclipse.ui.internal.quickaccess.SearchField$$Lambda$27/843005078.bindingManagerChanged(Unknown Source)
	at org.eclipse.jface.bindings.BindingManager.fireBindingManagerChanged(BindingManager.java:901)
	at org.eclipse.jface.bindings.BindingManager.setActiveBindings(BindingManager.java:2181)
	at org.eclipse.jface.bindings.BindingManager.recomputeBindings(BindingManager.java:1742)
	at org.eclipse.jface.bindings.BindingManager.contextManagerChanged(BindingManager.java:690)
	at org.eclipse.core.commands.contexts.ContextManager.fireContextManagerChanged(ContextManager.java:162)
	at org.eclipse.core.commands.contexts.ContextManager.setActiveContextIds(ContextManager.java:293)
	at org.eclipse.e4.ui.services.ContextServiceAddon$1.changed(ContextServiceAddon.java:46)
	at org.eclipse.e4.core.internal.contexts.TrackableComputationExt.update(TrackableComputationExt.java:114)
	at org.eclipse.e4.core.internal.contexts.EclipseContext.processScheduled(EclipseContext.java:342)
	at org.eclipse.e4.core.internal.contexts.EclipseContext.set(EclipseContext.java:357)
	at org.eclipse.e4.core.internal.contexts.EclipseContext.activate(EclipseContext.java:662)
	at org.eclipse.e4.ui.internal.workLeon Ochoach.swt.ShellActivationListener$2.run(ShellActivationListener.java:124)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.e4.ui.internal.workLeon Ochoach.swt.ShellActivationListener.activate(ShellActivationListener.java:120)
	at org.eclipse.e4.ui.internal.workLeon Ochoach.swt.ShellActivationListener.handleEvent(ShellActivationListener.java:74)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Display.filterEvent(Display.java:1594)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1339)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1366)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1345)
	at org.eclipse.swt.widgets.Shell.gtk_focus_in_event(Shell.java:1387)
	at org.eclipse.swt.widgets.Widget.windowProc(Widget.java:1996)
	at org.eclipse.swt.widgets.Control.windowProc(Control.java:5826)
	at org.eclipse.swt.widgets.Display.windowProc(Display.java:5444)
	at org.eclipse.swt.internal.gtk.OS._gtk_main_do_event(Native Method)
	at org.eclipse.swt.internal.gtk.OS.gtk_main_do_event(OS.java:9545)
	at org.eclipse.swt.widgets.Display.eventProc(Display.java:1275)
	at org.eclipse.swt.internal.gtk.OS._g_main_context_iteration(Native Method)
	at org.eclipse.swt.internal.gtk.OS.g_main_context_iteration(OS.java:2495)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:4099)
	at org.eclipse.jface.window.Window.runEventLoop(Window.java:818)
	at org.eclipse.jface.window.Window.open(Window.java:794)
	at org.eclipse.jface.dialogs.MessageDialog.open(MessageDialog.java:396)
	at org.eclipse.jface.dialogs.MessageDialogWithToggle.open(MessageDialogWithToggle.java:115)
	at org.eclipse.jface.dialogs.MessageDialogWithToggle.openOkCancelConfirm(MessageDialogWithToggle.java:210)
	at org.eclipse.ui.internal.ide.application.IDEWorkLeon OchoachWindowAdvisor.promptOnExit(IDEWorkbenchWindowAdvisor.java:213)
	at org.eclipse.ui.internal.ide.application.IDEWorkLeon OchoachWindowAdvisor.preWindowShellClose(IDEWorkbenchWindowAdvisor.java:166)
	at org.eclipse.ui.internal.WorkLeon OchoachWindow$6.close(WorkbenchWindow.java:524)
	at org.eclipse.e4.ui.workLeon Ochoach.renderers.swt.WBWRenderer$7.shellClosed(WBWRenderer.java:561)
	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:99)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Display.sendEvent(Display.java:5173)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1340)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1366)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1349)
	at org.eclipse.swt.widgets.Shell.closeWidget(Shell.java:660)
	at org.eclipse.swt.widgets.Shell.gtk_delete_event(Shell.java:1294)
	at org.eclipse.swt.widgets.Widget.windowProc(Widget.java:1981)
	at org.eclipse.swt.widgets.Control.windowProc(Control.java:5826)
	at org.eclipse.swt.widgets.Display.windowProc(Display.java:5444)
	at org.eclipse.swt.internal.gtk.OS._gtk_main_do_event(Native Method)
	at org.eclipse.swt.internal.gtk.OS.gtk_main_do_event(OS.java:9545)
	at org.eclipse.swt.widgets.Display.eventProc(Display.java:1275)
	at org.eclipse.swt.internal.gtk.OS._g_main_context_iteration(Native Method)
	at org.eclipse.swt.internal.gtk.OS.g_main_context_iteration(OS.java:2495)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:4099)
	at org.eclipse.e4.ui.internal.workLeon Ochoach.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1119)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
	at org.eclipse.e4.ui.internal.workLeon Ochoach.swt.PartRenderingEngine.run(PartRenderingEngine.java:1020)
	at org.eclipse.e4.ui.internal.workLeon Ochoach.E4Workbench.createAndRunUI(E4Workbench.java:150)
	at org.eclipse.ui.internal.WorkLeon Ochoach$5.run(Workbench.java:687)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
	at org.eclipse.ui.internal.WorkLeon Ochoach.createAndRunWorkbench(Workbench.java:604)
	at org.eclipse.ui.PlatformUI.createAndRunWorkLeon Ochoach(PlatformUI.java:148)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:138)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:497)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:673)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:610)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1519)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1492)

-------------------------------------
author: Brenden Conley
date: 2016-04-15 07:01:33.000000000

Patch Set 2: Verified-1

Build Failed 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/9135/ : FAILURE

-------------------------------------
author: Zaid Mosley
date: 2016-04-15 07:26:50.000000000

Patch Set 2:

Looks like listening to IBindingManager is a bit fishy. I will update the patch and listen for changes in preferences, this should also reduce the number of updates triggered.

-------------------------------------
author: Zaid Mosley
date: 2016-04-15 07:56:13.000000000

Patch Set 2:

I update Patriks patch with using a preference listener. Work fine for me.

-------------------------------------
author: Teagan Marsh
date: 2016-04-15 14:20:47.000000000

Abandoned

-------------------------------------
