DESCRIPTION

Bug 491312 - [Quick Access] Add shortcut to message of Quick Access Box
in the toolbar 

The Quick Access is now displaying the real shourtcut, 
and it is listening to KeyBindings change


Change-Id: I90ccd6e140c4b015b4fb8730c2be7c2f4979506b
Signed-off-by: Ryker Bauer xxx@xxx.xxx


COMMENTS

author: Zaid Mosley
date: 2016-04-15 07:44:12.000000000

Uploaded patch set 12.

-------------------------------------
author: Brenden Conley
date: 2016-04-15 07:44:26.000000000

Patch Set 12:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/9139/

-------------------------------------
author: Zaid Mosley
date: 2016-04-15 07:45:08.000000000

Patch Set 12:

Patrik, can you test this on Windows? Work flawless on Ubuntu 15.10

-------------------------------------
author: Brenden Conley
date: 2016-04-15 07:49:03.000000000

Patch Set 12: Verified-1

Build Failed 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/9139/ : FAILURE

-------------------------------------
author: Ryker Bauer
date: 2016-04-15 07:54:08.000000000

Patch Set 12: Code-Review-1

> Patrik, can you test this on Windows? Work flawless on Ubuntu 15.10

Almost done. there is an issue to solve in SearchField line 353 : 

triggerSequence = (binding==null)?null:binding.getTriggerSequence();

I see an exception when setting the binding to nothing

Caused by: java.lang.NullPointerException
	at org.eclipse.ui.internal.quickaccess.SearchField.updateQuickAccessTriggerSequence(SearchField.java:353)
	at org.eclipse.ui.internal.quickaccess.SearchField.updateQuickAccessText(SearchField.java:374)
	at org.eclipse.ui.internal.quickaccess.SearchField.keybindingPreferencesChanged(SearchField.java:312)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

-------------------------------------
author: Zaid Mosley
date: 2016-04-15 07:57:56.000000000

Patch Set 12:

Thanks Patrik, can you update the review with your fix?

-------------------------------------
author: Ryker Bauer
date: 2016-04-15 08:03:17.000000000

Patch Set 12: -Code-Review

> Thanks Patrik, can you update the review with your fix?
Yes, this will require also adding back the message "Quick Aceess" without parameter, to be used when no keybinding is attached.

-------------------------------------
author: Ryker Bauer
date: 2016-04-15 08:04:29.000000000

Patch Set 12:

(disregard previous comment)
 > > Thanks Patrik, can you update the review with your fix?

Sure, no probem!

-------------------------------------
author: Gerrit Code Review
date: 2016-04-15 08:40:02.000000000

Change has been successfully merged into the git repository by Zaid Mosley

-------------------------------------
