DESCRIPTION

Bug 196692 - Forms cannot handle most kinds of wrapping controls

Note that if this change is reverted or cherry-picked, you must also
include the previous change xxx@xxx.xxx as well.

Change-Id: I781fab28ce427874f9d41662a98a1ebfa3840b18


COMMENTS

author: Kelly Potter
date: 2017-05-04 16:35:51.000000000

Uploaded patch set 21.

-------------------------------------
author: Brenden Conley
date: 2017-05-04 16:35:59.000000000

Patch Set 21:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/12643/

-------------------------------------
author: Kelly Potter
date: 2017-05-04 16:40:49.000000000

Patch Set 21: -Code-Review

I've sorted out all the known regressions.

-------------------------------------
author: Zaid Mosley
date: 2017-05-04 16:54:19.000000000

Patch Set 21:

Great news Stefan. If this is ready please commit today to have it in M7

-------------------------------------
author: Brenden Conley
date: 2017-05-04 17:05:01.000000000

Patch Set 21: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/12643/ : SUCCESS

-------------------------------------
author: Esteban Sparks
date: 2017-05-04 18:00:51.000000000

Patch Set 21:

(6 comments)

Line:664, bundles/org.eclipse.ui.forms/src/org/eclipse/ui/forms/widgets/TableWrapLayout.java -> This can fit in the previous line. (Or at least be consistent and put each field on it's own line.)

Line:58, bundles/org.eclipse.ui.forms/src/org/eclipse/ui/internal/forms/widgets/FormUtil.java -> Add method description.

Line:175, bundles/org.eclipse.ui.forms/src/org/eclipse/ui/internal/forms/widgets/FormHeading.java -> What does cw mean? Should H be capitalized?

Line:356, bundles/org.eclipse.ui.forms/src/org/eclipse/ui/internal/forms/widgets/FormHeading.java -> Incomplete.

Line:28, tests/org.eclipse.ui.tests.forms/forms/org/eclipse/ui/tests/forms/widgets/HintAdjustmentTest.java -> Add comment describing what this is testing.

Line:16, tests/org.eclipse.ui.tests.forms/forms/org/eclipse/ui/tests/forms/layout/ControlFactory.java -> Add comment

-------------------------------------
author: Gerrit Code Review
date: 2017-05-04 20:04:36.000000000

Change has been successfully merged into the git repository by Kelly Potter

-------------------------------------
