DESCRIPTION

Bug 489382 - [Databinding] Provide a composite ISideEffect

Change-Id: Ia10cc2baf6f978a3d6a41e3a54338615236a5338
Also-By: Kelly Potter xxx@xxx.xxx
Signed-off-by: Krista Shepherd xxx@xxx.xxx


COMMENTS

author: Krista Shepherd
date: 2016-04-18 17:21:50.000000000

Uploaded patch set 25.

-------------------------------------
author: Brenden Conley
date: 2016-04-18 17:21:57.000000000

Patch Set 25:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/9169/

-------------------------------------
author: Krista Shepherd
date: 2016-04-18 17:26:50.000000000

Patch Set 25:

I've pushed the last issues Sergey mentioned. Except for the formatting issues. I somehow also prefer having this line at the beginning of the class, but do not insist on having such a line.

-------------------------------------
author: Brock Pruitt
date: 2016-04-18 17:28:42.000000000

Patch Set 25:

(2 comments)

Line:156, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/observable/SideEffect.java -> often -> times

Line:138, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/observable/sideeffect/CompositeSideEffect.java -> often -> times

-------------------------------------
author: Brenden Conley
date: 2016-04-18 17:50:38.000000000

Patch Set 25: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/9169/ : SUCCESS

-------------------------------------
author: Gerrit Code Review
date: 2016-04-20 22:10:47.000000000

Change has been successfully merged into the git repository by Krista Shepherd

-------------------------------------
