DESCRIPTION

Bug 478611 - [DataBinding] Create snippets for the SideEffect class

Change-Id: I5e677f6ff85fd35f0bb9e5da8436a7b7a3c4d75e
Signed-off-by: Krista Shepherd xxx@xxx.xxx

COMMENTS

author: Krista Shepherd
date: 2016-03-08 02:29:15.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2016-03-08 02:29:21.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/8487/

-------------------------------------
author: Brenden Conley
date: 2016-03-08 02:54:56.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/8487/ : SUCCESS

-------------------------------------
author: Kelly Potter
date: 2016-03-10 05:20:34.000000000

Patch Set 1: Code-Review-1

(3 comments)

Minor suggestion to simplify the layout code.

Line:39, examples/org.eclipse.jface.examples.databinding/src/org/eclipse/jface/examples/databinding/snippets/SnippetSideEffectAggregateValidationStatus.java -> Delete the attachment of a gridlayout here. (see below)

Line:48, examples/org.eclipse.jface.examples.databinding/src/org/eclipse/jface/examples/databinding/snippets/SnippetSideEffectAggregateValidationStatus.java -> Delete the usage of GridDataFactory here (see below)

Line:70, examples/org.eclipse.jface.examples.databinding/src/org/eclipse/jface/examples/databinding/snippets/SnippetSideEffectAggregateValidationStatus.java -> Invoke this:

GridLayoutFactory.fillDefaults().numColumns(2).generate(shell)

-------------------------------------
