DESCRIPTION

Bug 354538 - Window menus and toolbars leaked after having been closed

The sub-menus were not removed from the maps on which the leaks appeared
on the clean methods of
org.eclipse.e4.ui.workLeon Ochoach.renderers.swt.MenuManagerRenderer

Change-Id: I2527a4fb9b93da3ff3ae99136f844e45218ab63f
Signed-off-by: Karter Mora xxx@xxx.xxx

COMMENTS

author: Rylee Bush
date: 2016-02-24 16:58:02.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2016-02-24 16:58:07.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/8375/

-------------------------------------
author: Brenden Conley
date: 2016-02-24 17:54:00.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/8375/ : SUCCESS

-------------------------------------
author: Isis Velasquez
date: 2016-02-29 14:08:44.000000000

Patch Set 1: Code-Review+1

Code seems good enough IMO.

-------------------------------------
author: Sebastian Porter
date: 2016-03-02 10:31:31.000000000

Patch Set 1:

Did you verify that it fixes the leaks by running the UITestSuite and trace? See https://git.eclipse.org/r/#/c/23999/ for such a trace.

-------------------------------------
author: Rylee Bush
date: 2016-03-04 14:21:37.000000000

Patch Set 1:

Here are the results of UITestSuite & trace before modifications:
BEGIN OF TEST SUITE
Before clean up: managerToModel = 27
Before clean up: contributionToModel = 234
After clean up: managerToModel = 27
After clean up: contributionToModel = 234
Before clean up: managerToModel = 32
Before clean up: contributionToModel = 253
After clean up: managerToModel = 32
After clean up: contributionToModel = 253
…
After clean up: managerToModel = 4761
After clean up: contributionToModel = 53258
Before clean up: managerToModel = 4760
Before clean up: contributionToModel = 53258
After clean up: managerToModel = 4760
After clean up: contributionToModel = 53258
Before clean up: managerToModel = 4759
Before clean up: contributionToModel = 53258
After clean up: managerToModel = 4759
After clean up: contributionToModel = 53258
Before clean up: managerToModel = 4758
Before clean up: contributionToModel = 53258
After clean up: managerToModel = 4758
After clean up: contributionToModel = 53258
Before clean up: managerToModel = 4757
Before clean up: contributionToModel = 53258
After clean up: managerToModel = 4757
After clean up: contributionToModel = 53258
After clean up: managerToModel = 4756
After clean up: contributionToModel = 53258
END OF TEST SUITE
-----------------------------------------------------------------
Here are the results of UITestSuite & trace after modifications:
BEGIN OF TEST SUITE
Before clean up: managerToModel = 27
Before clean up: contributionToModel = 234
After clean up: managerToModel = 27
After clean up: contributionToModel = 234
Before clean up: managerToModel = 32
Before clean up: contributionToModel = 253
After clean up: managerToModel = 32
After clean up: contributionToModel = 253
…
Before clean up: managerToModel = 20
Before clean up: contributionToModel = 170
After clean up: managerToModel = 20
After clean up: contributionToModel = 170
Before clean up: managerToModel = 19
Before clean up: contributionToModel = 170
After clean up: managerToModel = 19
After clean up: contributionToModel = 170
Before clean up: managerToModel = 18
Before clean up: contributionToModel = 170
After clean up: managerToModel = 18
After clean up: contributionToModel = 170
Before clean up: managerToModel = 17
Before clean up: contributionToModel = 170
After clean up: managerToModel = 17
After clean up: contributionToModel = 170
After clean up: managerToModel = 16
After clean up: contributionToModel = 170
END OF TEST SUITE

-------------------------------------
author: Zaid Mosley
date: 2016-03-04 22:08:23.000000000

Patch Set 1: Code-Review+1 Verified+1

Change and trace looks good to me.

-------------------------------------
author: Rylee Bush
date: 2016-03-14 08:00:11.000000000

Patch Set 1:

Hi, with two +1, may be this review could be merged ? Or someone else need to review it ?

-------------------------------------
author: Gerrit Code Review
date: 2017-02-01 22:08:53.000000000

Change has been successfully merged into the git repository by Jayvion Booth

-------------------------------------
