DESCRIPTION

Bug 392457 - Cannot create dynamic Status bar controls in eclipse 4.2

Fix dynamic toolbar controls who not appear in Eclipse 4.x.

Change-Id: I9d57ff2dd844e43c2973fd2a0c6b52fbe6ee9198
Signed-off-by: Karter Mora xxx@xxx.xxx

COMMENTS

author: Rylee Bush
date: 2016-02-29 15:54:30.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2016-02-29 15:54:42.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/8416/

-------------------------------------
author: Brenden Conley
date: 2016-02-29 17:10:25.000000000

Patch Set 2: Verified-1

Build Failed 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/8416/ : FAILURE

-------------------------------------
author: Brenden Conley
date: 2016-02-29 17:23:12.000000000

Patch Set 2: -Verified

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/8420/

-------------------------------------
author: Brenden Conley
date: 2016-02-29 17:55:38.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/8420/ : SUCCESS

-------------------------------------
author: Rylee Bush
date: 2016-03-03 10:55:53.000000000

Patch Set 2:

Is there anybody else to review this code and confirm Mickaël point of view ?

-------------------------------------
author: Rylee Bush
date: 2016-03-14 08:04:46.000000000

Patch Set 2:

Hi Brian,

Ok I will take a look at MenuBaseTests.java and try to do something similar for the dynamic controls in toolbar. 

Thank you.

-------------------------------------
author: Rylee Bush
date: 2016-03-14 13:56:05.000000000

Patch Set 2:

MenuBaseTests & DynamicMenuTest already tests dynamic contributions but are not enabled. I propose to enable these tests. What do you think about it ?

-------------------------------------
author: Teagan Marsh
date: 2016-03-16 14:46:40.000000000

Patch Set 2:

> MenuBaseTests & DynamicMenuTest already tests dynamic contributions
 > but are not enabled. I propose to enable these tests. What do you
 > think about it ?

They should definitely be enabled.  But unless I'm missing something, they test menu contributions, not toolbar contributions.

-------------------------------------
author: Gerrit Code Review
date: 2016-04-20 19:33:09.000000000

Change has been successfully merged into the git repository by Teagan Marsh

-------------------------------------
