DESCRIPTION

Bug 488145 - [Databinding] ComputedValue should provide a factory method

Change-Id: Id3c010eb07973149f78156091d2154ab0ccffb35
Signed-off-by: Krista Shepherd xxx@xxx.xxx

COMMENTS

author: Krista Shepherd
date: 2016-02-20 00:54:24.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2016-02-20 00:54:30.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/8307/

-------------------------------------
author: Brenden Conley
date: 2016-02-20 01:17:34.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/8307/ : SUCCESS

-------------------------------------
author: Kelly Potter
date: 2016-02-20 02:12:09.000000000

Patch Set 1:

(4 comments)

Nice job.

Line:92, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/value/ComputedValue.java -> Use &lt; and &gt; instead < and >

Line:96, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/value/ComputedValue.java -> Reword. Suggested wording:

{@link Supplier}, whose {@link Supplier#get()} method is a TrackedGetter. See xxx@xxx.xxx ObservableTracker#getterCalled(IObservable)} for details.

Line:100, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/value/ComputedValue.java -> Suggested rewording:

{@link ComputedValue} whose value is computed using the given xxx@xxx.xxx Supplier}.

Line:104, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/value/ComputedValue.java -> Unnecessary whitespace.

-------------------------------------
author: Gerrit Code Review
date: 2016-02-20 03:05:24.000000000

Change has been successfully merged into the git repository by Krista Shepherd

-------------------------------------
