DESCRIPTION

Bug 476633 - NPE in
org.eclipse.e4.ui.internal.workLeon Ochoach.SelectionServiceImpl.getSelection()

adding null checks for SelectionAggregator

Change-Id: I84781c1d9cf20ad678f52c7f160fb854a5050023
Signed-off-by: Makai Yu xxx@xxx.xxx

COMMENTS

author: Brenden Conley
date: 2016-02-18 13:53:25.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/8305/

-------------------------------------
author: Brenden Conley
date: 2016-02-18 14:35:08.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/8305/ : SUCCESS

-------------------------------------
author: Teagan Marsh
date: 2016-02-18 16:00:14.000000000

Patch Set 2:

(1 comment)

Line:130, bundles/org.eclipse.e4.ui.workLeon Ochoach/src/org/eclipse/e4/ui/internal/workbench/SelectionServiceImpl.java -> This code seems weird — it's possible that I add a selection listener to the app's ESelectionService (so I should be notified of selection changes on all windows) but my listener *could* be just added to the selected window.

Seems like an attempt to avoid having to perform null handling like you've added above.  Were you able to reproduce the situations getting NPEs?

-------------------------------------
author: Jared Jackson
date: 2016-02-19 16:26:22.000000000

Patch Set 3: Patch Set 2 was rebased

-------------------------------------
author: Gerrit Code Review
date: 2016-02-19 18:15:52.000000000

Change has been successfully merged into the git repository by Jared Jackson

-------------------------------------
