DESCRIPTION

Bug 480610 - Add Tests for ModelAssembler

Refactored ModelAssembler and added tests

Change-Id: Iaa809d9165f877f89a14fa5b68eb1246eed6c366
Signed-off-by: Corbin Edwards xxx@xxx.xxx

COMMENTS

author: Brenden Conley
date: 2016-03-23 02:42:09.000000000

Patch Set 14:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/8690/

-------------------------------------
author: Emma Robertson
date: 2016-03-23 02:42:13.000000000

Patch Set 14: Code-Review+1

-------------------------------------
author: Brenden Conley
date: 2016-03-23 03:10:57.000000000

Patch Set 14: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/8690/ : SUCCESS

-------------------------------------
author: Emma Robertson
date: 2016-03-24 12:34:40.000000000

Patch Set 14:

@Brian, Lars: any vetos? otherwise I would submit this...

-------------------------------------
author: Teagan Marsh
date: 2016-03-24 14:22:43.000000000

Patch Set 14:

(2 comments)

I would never veto tests and improvements from refactoring!

Line:66, tests/org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/workLeon Ochoach/ModelAssemblerTests.java -> Typically string constants like this are all uppercase (see IPresentationEngine, for example)

Line:99, tests/org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/workLeon Ochoach/ModelAssemblerTests.java -> Typically annotation is put next to the method

-------------------------------------
author: Corbin Edwards
date: 2016-03-29 07:25:56.000000000

Patch Set 14:

(2 comments)

Line:66, tests/org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/workLeon Ochoach/ModelAssemblerTests.java -> Done

Line:99, tests/org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/workLeon Ochoach/ModelAssemblerTests.java -> Done

-------------------------------------
author: Gerrit Code Review
date: 2016-03-29 17:07:34.000000000

Change has been successfully merged into the git repository by Emma Robertson

-------------------------------------
