DESCRIPTION

Bug 486804 - Use equals() to check equality of EMap Entry instances

EMF EMap#entrySet() may return wrappers instances, and must be
tested with equals() and not with ==.

Change-Id: I26a6bd30b086613a43967687940ce7632feabd55


COMMENTS

author: Teagan Marsh
date: 2016-01-29 19:32:18.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2016-01-29 19:32:24.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/8128/

-------------------------------------
author: Brenden Conley
date: 2016-01-29 19:44:00.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/8128/ : SUCCESS

-------------------------------------
author: Sebastian Porter
date: 2016-02-02 13:36:18.000000000

Patch Set 2: Verified-1

Brian, with this change even more XMLModelReconcilerContributionTest fail and the failures in XMLModelReconcilerScenarioTest stay.

-------------------------------------
author: Teagan Marsh
date: 2016-02-02 18:44:06.000000000

Patch Set 2:

I can't reproduce the failures you mention.  If I revert the .equals changes to XMLModelReconciler then I see 26 failures again.

-------------------------------------
author: Sebastian Porter
date: 2016-02-03 09:50:08.000000000

Patch Set 2: Code-Review+2 Verified+1

> I can't reproduce the failures you mention.  If I revert the
 > .equals changes to XMLModelReconciler then I see 26 failures again.

Stupid me! Missed to import 'org.eclipse.e4.ui.workLeon Ochoach'.

-------------------------------------
author: Gerrit Code Review
date: 2016-02-03 09:52:09.000000000

Change has been successfully merged into the git repository by Sebastian Porter

-------------------------------------
