DESCRIPTION

Bug 486665 - API breakage of IDE#getEditorDescription

This introduces a new flag on getEditorDescriptor methods to tell
whether interaction with user is allowed.

Change-Id: I663e0a5165ecb3cbd45911c3dfe36ce78e80c03c
Signed-off-by: Isis Velasquez xxx@xxx.xxx


COMMENTS

author: Isis Velasquez
date: 2016-02-22 12:44:39.000000000

Uploaded patch set 9.

-------------------------------------
author: Brenden Conley
date: 2016-02-22 12:44:46.000000000

Patch Set 9:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/8320/

-------------------------------------
author: Brenden Conley
date: 2016-02-22 13:12:20.000000000

Patch Set 9: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/8320/ : SUCCESS

-------------------------------------
author: Sebastian Porter
date: 2016-02-22 14:34:50.000000000

Patch Set 9:

> This new patch set removes the OperationCanceledException from
 > legacy methods. I'm not sure about the best way to restore
 > behavior: should I add yet another flag to entirely skip the
 > IUnassociatedEditorStrategy? The current flag only skips if the
 > selected one is interactive.

The old and deprecated methods must just do it the <= 4.5 way. I would not add a second flag. If you can't do it with one flag, then just keep the code as it was in 4.5, even if we duplicate it.

-------------------------------------
author: Gerrit Code Review
date: 2016-03-02 11:25:55.000000000

Project policy requires all submissions to be a fast-forward.

Please rebase the change locally and upload again for review.

-------------------------------------
author: Gerrit Code Review
date: 2016-03-02 11:26:28.000000000

Change has been successfully merged into the git repository by Sebastian Porter

-------------------------------------
