DESCRIPTION

Bug 409633 - Lock the toolbars command not working 

Implemented setLockLayout(boolean) to toggle the "locked" status of the
toolbars. 
The status is changed by adding/removing the IPresentationEngine.NO_MOVE
tag to all the MToolBar of the window, not tagged as TOOLBAR_SEPARATOR.
The "locked" status is persisted across restarts.

Change-Id: Ic0a44f0eb8b0519802cc317623d0d5593a1a778a
Signed-off-by: Ryker Bauer xxx@xxx.xxx

COMMENTS

author: Brenden Conley
date: 2016-04-26 13:37:19.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/9282/

-------------------------------------
author: Brenden Conley
date: 2016-04-26 13:45:11.000000000

Patch Set 3: Verified-1

Build Failed 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/9282/ : FAILURE

-------------------------------------
author: Teagan Marsh
date: 2016-04-26 13:57:40.000000000

Patch Set 3:

(1 comment)

I'm somewhat torn here.  Having a rendering object make a change to the model tags doesn't seem right. It would seem to me that you should look at the callers of CSSRenderingUtils#frameMeIfPossible(), which installs the drag handles, and figure out how their logic should change for determining if the drag handles should be installed.

If you continue with this approach, this code won't be adequate as it also needs to deal with additions and removals from the toolbar.

Line:531, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/CoolBarToTrimManager.java -> So from a readability perspective… deliberately having two loops implies that there's something different about the two loops. If you combine them into one loop with the logic inside.

-------------------------------------
author: Ryker Bauer
date: 2017-04-08 10:25:54.000000000

Patch Set 4: Patch Set 3 was rebased

-------------------------------------
author: Ryker Bauer
date: 2017-04-09 08:49:51.000000000

Patch Set 3:

(1 comment)

I looked at the callers of I looked at the callers of frameMeIfPossible(), which is called only in createWidget().
I would proceed fixing this way, so the lock toolbars start working.
Then, I will add a second bug, to display/hide the drag handle.

Line:531, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/CoolBarToTrimManager.java -> Done

-------------------------------------
author: Gerrit Code Review
date: 2017-04-10 17:26:01.000000000

Change has been successfully merged into the git repository by Ryker Bauer

-------------------------------------
