DESCRIPTION

Bug 479217 - Fix warnings in AbstractWorkingSetManager

Change-Id: I2521b86f8bef537c4b80ff0fa56b2891d596806a
Signed-off-by: Kelly Potter xxx@xxx.xxx


COMMENTS

author: Kelly Potter
date: 2016-01-15 19:25:35.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2016-01-15 19:25:41.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/8025/

-------------------------------------
author: Brenden Conley
date: 2016-01-15 19:48:32.000000000

Patch Set 1: Code-Review-1

Build Unstable 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/8025/ : UNSTABLE

-------------------------------------
author: Brock Pruitt
date: 2016-01-15 21:45:41.000000000

Patch Set 1: Code-Review+1

(7 comments)

Line:164, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/AbstractWorkingSetManager.java -> Merge with the previous line.

Line:257, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/AbstractWorkingSetManager.java -> Would TreeSet<> be sufficient?

Line:258, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/AbstractWorkingSetManager.java -> Merge with the previous line.

Line:270, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/AbstractWorkingSetManager.java -> Merge with the previous line.

Line:748, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/AbstractWorkingSetManager.java -> Merge with the previous line (at least ".getDeclaringExtension(),")

Line:759, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/AbstractWorkingSetManager.java -> Merge with the previous line.

Line:774, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/AbstractWorkingSetManager.java -> Merge with the previous line.

-------------------------------------
author: Kelly Potter
date: 2016-01-16 06:31:13.000000000

Patch Set 1:

(6 comments)

Line:257, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/AbstractWorkingSetManager.java -> I tried it. It doesn't compile.

Line:258, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/AbstractWorkingSetManager.java -> Done

Line:270, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/AbstractWorkingSetManager.java -> Done

Line:748, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/AbstractWorkingSetManager.java -> Done

Line:759, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/AbstractWorkingSetManager.java -> Done

Line:774, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/AbstractWorkingSetManager.java -> Done

-------------------------------------
author: Gerrit Code Review
date: 2016-04-08 03:18:21.000000000

Change has been successfully merged into the git repository by Kelly Potter

-------------------------------------
