DESCRIPTION

Bug 485840 - NPE im PerspectiveSwitcher#closePerspective

Using the perspective to find the MWindow results in a NPE, if the
perspective has not been opened yet. This patch uses the injected window
to access the page.


Change-Id: I49c25ece222743d54e8e188bb8acf6c63abe1248
Signed-off-by: Zaid Mosley xxx@xxx.xxx

COMMENTS

author: Zaid Mosley
date: 2016-01-22 14:05:53.000000000

Patch Set 4: Published edit on patch set 3

-------------------------------------
author: Zaid Mosley
date: 2016-01-22 14:06:33.000000000

Patch Set 4: Code-Review+2 Verified+1

Committing this to test it during M5 validation.

-------------------------------------
author: Gerrit Code Review
date: 2016-01-22 14:06:35.000000000

Change has been successfully merged into the git repository by Zaid Mosley

-------------------------------------
author: Brenden Conley
date: 2016-01-22 14:19:46.000000000

Patch Set 4:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/8081/

-------------------------------------
author: Teagan Marsh
date: 2016-01-22 14:37:27.000000000

Patch Set 4:

> Brian, what do you think? Is this the correct fix?

Sorry, I didn't post comments in here as I thought (and think) it's a different issue.  But I don't think this is the right fix as there are other calls to EModelService.getTopLevelWindowFor() within the code — there's something fishy going on.  I don't think this is a good change.

-------------------------------------
author: Brenden Conley
date: 2016-01-22 14:57:34.000000000

Patch Set 4:

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/8081/ : SUCCESS

-------------------------------------
