DESCRIPTION

Bug 479126 PERSPECTIVE_BAR_EXTRAS setting not taken into account

Change-Id: I20a2bc34fc9d25f442705488784cd7b3ca31032d
Signed-off-by: Bruno House xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2016-01-14 14:59:32.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/7995/

-------------------------------------
author: Brenden Conley
date: 2016-01-14 15:56:49.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/7995/ : SUCCESS

-------------------------------------
author: Emma Robertson
date: 2016-01-15 09:49:10.000000000

Patch Set 2: Code-Review+1

(1 comment)

please have a look at the comment

Line:5535, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java -> Isnt this the same as "this"? Meaning, arent we in the relevant Workbenchpage?

-------------------------------------
author: Bruno House
date: 2016-01-15 10:16:10.000000000

Patch Set 2:

(1 comment)

Line:5535, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java -> You're right, I did not adapt this piece when I moved the method from PerspectiveSwitcher to here.

-------------------------------------
author: Emma Robertson
date: 2016-01-15 12:35:15.000000000

Patch Set 2:

(1 comment)

Thanks!

Line:5535, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java -> Done

-------------------------------------
author: Gerrit Code Review
date: 2016-01-15 13:27:56.000000000

Change has been successfully merged into the git repository by Emma Robertson

-------------------------------------
