DESCRIPTION

Bug 485128 - "Open Resource" dialog should also match substrings

Change-Id: I1cbe02a0397a8f19f73687eb69488fa2a99884d3
Signed-off-by: Zaid Mosley xxx@xxx.xxx

COMMENTS

author: Zaid Mosley
date: 2016-01-04 12:43:19.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2016-01-04 12:43:25.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/7817/

-------------------------------------
author: Isis Velasquez
date: 2016-01-04 12:48:21.000000000

Patch Set 1: Code-Review+1

This seems correct, although it only fix a subset of bug 485128 (this adds prefix search, but would match pom.xml when given pm.xml).

-------------------------------------
author: Isis Velasquez
date: 2016-01-04 12:51:00.000000000

Patch Set 1:

(2 comments)

Line:2310, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/dialogs/FilteredItemsSelectionDialog.java -> I wouldn't match the "." here. When using the open resource dialog, using "." is most often used as the actual dot, not as the replacement for any character.

Line:2311, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/dialogs/FilteredItemsSelectionDialog.java -> Maybe even something like stringPattern = stringPattern.replace(".", "*.")

-------------------------------------
author: Isis Velasquez
date: 2016-01-04 12:52:55.000000000

Patch Set 1:

(1 comment)

Line:2311, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/dialogs/FilteredItemsSelectionDialog.java -> replaceAll

-------------------------------------
author: Brenden Conley
date: 2016-01-04 12:58:53.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/7817/ : SUCCESS

-------------------------------------
