DESCRIPTION

Merge branch 'master' of
http://git.eclipse.org/gitroot/platform/eclipse.platform.ui.git
Signed-off-by: Bruno House xxx@xxx.xxx

COMMENTS

author: Bruno House
date: 2015-12-17 10:57:41.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2015-12-17 10:57:48.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/7778/

-------------------------------------
author: Brenden Conley
date: 2015-12-17 11:08:16.000000000

Patch Set 1: Verified-1

Build Failed 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/7778/ : FAILURE

-------------------------------------
author: Bruno House
date: 2015-12-17 11:10:19.000000000

Patch Set 1:

(1 comment)

Line:2702, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java -> After communicating with Jonas by email he said to create the extras in this general area. Worked for my simple test.

-------------------------------------
author: Teagan Marsh
date: 2015-12-17 16:28:19.000000000

Patch Set 1:

(3 comments)

Thanks for your submission, Manual.  A few little tweaks, and could you please flatten your commit and use the guidelines for commit messages?

https://wiki.eclipse.org/Platform_UI/How_to_Contribute#Commit_Message_Conventions

Line:4070, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java -> Although it may seem that PerspectiveSwitcher was the only user of this method, it may be used elsewhere.  We try not to reduce the visibility of methods unless the method is broken.

Line:5501, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java -> I know this was in the existing code, but String.split() actually takes a regex, so we can simplify this code and just use

   persps.split("[, ]");

Line:5527, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java -> getWorkbenchWindow().getWorkbench() — please avoid using PlatformUI.getWorkbench()

-------------------------------------
author: Bruno House
date: 2016-01-11 14:13:31.000000000

Patch Set 1:

(3 comments)

I created this gerrit change unintentionally, so I redid the changes here plus 2 of brians tweaks in https://git.eclipse.org/r/#/c/58607

Line:4070, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java -> I introduced this method (by refactoring) in https://git.eclipse.org/r/#/c/58607 i.e. it is totally new, no one else could possibly use it, since that review has not been submitted yet.

Line:5501, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java -> ok

Line:5527, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java -> ok

-------------------------------------
author: Bruno House
date: 2016-01-13 09:53:22.000000000

Patch Set 1:

All work for this bugzilla now done in: https://git.eclipse.org/r/#/c/64214/

-------------------------------------
author: Bruno House
date: 2016-01-15 13:05:21.000000000

Abandoned

-------------------------------------
