DESCRIPTION

Bug 477391 - Provide a deferred way to create ImageDescriptors in JFace

Change-Id: Ic547e3014bdce54f736faed17f7dbf6f3c544232
Signed-off-by: Irvin Riggs xxx@xxx.xxx


COMMENTS

author: Irvin Riggs
date: 2015-12-05 05:36:12.000000000

Uploaded patch set 4.

-------------------------------------
author: Brenden Conley
date: 2015-12-05 05:36:18.000000000

Patch Set 4:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/7703/

-------------------------------------
author: Brenden Conley
date: 2015-12-05 05:40:21.000000000

Patch Set 4: Verified-1

Build Failed 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/7703/ : FAILURE

-------------------------------------
author: Kelly Potter
date: 2015-12-07 18:17:36.000000000

Patch Set 4:

(2 comments)

Line:20, bundles/org.eclipse.jface/src/org/eclipse/jface/resource/SuppliedImageDescriptor.java -> private final Supplier...

Line:109, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/WorkbenchImages.java -> Suggest retaining the local variables and keeping the calls to find and createFromUrl on different lines.

-------------------------------------
author: Kelly Potter
date: 2015-12-07 18:43:16.000000000

Patch Set 4: Code-Review-1

(3 comments)

Line:11, bundles/org.eclipse.jface/src/org/eclipse/jface/resource/JFaceResources.java -> (Google) is sufficient in this context.

Line:133, bundles/org.eclipse.jface/src/org/eclipse/jface/resource/ImageDescriptor.java -> Inconsistent indentation.

Missing JavaDoc for body.

Missing JavaDoc for "supplier" (must specify that the supplier will be invoked on the UI thread, must not return null, and will supply the image data returned by ImageDescriptor.

Line:12, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/WorkbenchImages.java -> (Google) is sufficient in this context.

-------------------------------------
author: Gerrit Code Review
date: 2015-12-08 00:39:30.000000000

Change has been successfully merged into the git repository by Kelly Potter

-------------------------------------
