DESCRIPTION

Bug 483011 - [Help] Direct Menu Item doesn't handle help request

Added support for handleHelpRequest using the elemnt id as the commandid
to retrieve the helpid from the commandhelpservice

Change-Id: Id8095eb3c99dd47988958de9d6b3daccf47b5a6c
Signed-off-by: Makayla Callahan xxx@xxx.xxx

COMMENTS

author: Makayla Callahan
date: 2015-11-25 15:22:45.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2015-11-25 15:22:51.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/7574/

-------------------------------------
author: Brenden Conley
date: 2015-11-25 15:50:09.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/7574/ : SUCCESS

-------------------------------------
author: Myah Faulkner
date: 2015-11-25 20:39:21.000000000

Patch Set 1:

If you copied the code from HandledContributionItem, why don't you consider moving the code to the abstract super class to avoid code duplication?

-------------------------------------
author: Makayla Callahan
date: 2015-11-26 07:23:29.000000000

Patch Set 1:

I wanted to have a feedback on the issue first.
Moving the code up, would introduce a new method in the super class. This would be either a method for retrieving the "commandId" which is strange in the super class as it doesn't know about commands. So it should be something like getHelpId, which leads also to code duplication as the commandhelpService is reused for retrieving the helpid currently.

-------------------------------------
author: Teagan Marsh
date: 2015-11-27 16:34:06.000000000

Patch Set 1:

I don't think treating the elementId as a commandId makes sense — they would likely just use a HandledContributionItem in that case.  Perhaps this is a case for a persistedState key like HELP_CONTEXT_ID?

-------------------------------------
author: Makayla Callahan
date: 2015-11-27 17:09:09.000000000

Patch Set 1:

I agree, that the elementId is not a perfect alternative for the commandid. But the problem already exists in the HandledContributionItem as there is no e4 specific ICommandHelpService implementation. There is a bug for this without an answer yet: https://bugs.eclipse.org/bugs/show_bug.cgi?id=468636

-------------------------------------
author: Gerrit Code Review
date: 2016-03-24 15:16:18.000000000

Change has been successfully merged into the git repository by Emma Robertson

-------------------------------------
