DESCRIPTION

Bug 472614 - Smarter import

This wizard and framework allows contributors to contribute a project
detector and configurator. Those detectors are used by this import
framework to automatically identify projects in a given directory. Then
matching projects that have been detected and selected for import are
automatically configured as specified in the contributed class.
Contributors are expected to look at details in the various files to set
as much project properties as possible.
Contributors are expected to be language or framework support, such as
Java support looking for Java file and enabling Java nature and setting
classpath; OSGi support looking for MANIFEST.MF and enabling the
necessary nature...
From user perspective, the operation is only about providing a folder,
reviewing some proposals and hitting finish, and to enjoy project(s)
ready to work with in the IDE.

Bug: 472614
Change-Id: I8ce21fd9fcc696726b1cd082ef01b05bd182826d
Signed-off-by: Isis Velasquez xxx@xxx.xxx


COMMENTS

author: Isis Velasquez
date: 2016-02-05 07:45:40.000000000

Uploaded patch set 5.

-------------------------------------
author: Brenden Conley
date: 2016-02-05 07:45:47.000000000

Patch Set 5:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/8208/

-------------------------------------
author: Brenden Conley
date: 2016-02-05 08:20:05.000000000

Patch Set 5: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/8208/ : SUCCESS

-------------------------------------
author: Zaid Mosley
date: 2016-02-05 09:13:05.000000000

Patch Set 5:

(22 comments)

Line:33, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/wizards/datatransfer/EclipseProjectConfigurator.java -> remove

Line:50, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/wizards/datatransfer/EclipseProjectConfigurator.java -> Can we use SubProgressMonitor.split here for automatic cancellation checks?

Line:630, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/wizards/datatransfer/SmartImportJob.java -> remove ws

Line:2425, bundles/org.eclipse.ui.ide/plugin.xml -> ws

Line:2483, bundles/org.eclipse.ui.ide/plugin.xml -> ws

Line:46, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/wizards/datatransfer/expressions/HasFolderExpression.java -> Adapters.adapt

Line:41, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/wizards/datatransfer/expressions/HasFileWithSuffixRecursivelyExpression.java -> Will also be handled by Adapters.adapt

Line:43, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/wizards/datatransfer/expressions/HasFileWithSuffixRecursivelyExpression.java -> Replace with Adapters.adapt

Line:125, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/wizards/datatransfer/SmartImportJobReportDialog.java -> Remove dead code

Line:137, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/wizards/datatransfer/SmartImportJobReportDialog.java -> Why not using ArrayContentProvider.getInstance?

Line:148, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/wizards/datatransfer/SmartImportJobReportDialog.java -> If you switch to ArrrayContentProvider you have to do this before the setInput

Line:221, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/wizards/datatransfer/SmartImportJobReportDialog.java -> Same here, I would simply use ArrayContentProvider

Line:322, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/wizards/datatransfer/SmartImportJobReportDialog.java -> We only use the "this." style in platform if necessary, e.g., for setter. Remove this if not necessary

Line:28, bundles/org.eclipse.ui.ide/schema/projectConfigurators.exsd -> Can you remove the ws?

Line:204, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/wizards/datatransfer/messages.properties -> remove ws

Line:206, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/wizards/datatransfer/messages.properties -> remove ws

Line:14, bundles/org.eclipse.ui.ide/plugin.properties -> Please use the bug reference not a text

Line:220, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/wizards/datatransfer/SmartImportRootWizardPage.java -> I suggest to use the vararg constructor

Line:28, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/wizards/datatransfer/ConfigureProjectHandler.java -> Remove ws

Line:39, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/wizards/datatransfer/ConfigureProjectHandler.java -> Please use our new 4.6 API: Adapters.adapt

Line:91, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/wizards/datatransfer/OpenFolderCommand.java -> I would return null. The return value of AbstractHandler is not used by the platform.

Line:25, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/wizards/datatransfer/RecursiveFileFinder.java -> remove ws

-------------------------------------
author: Isis Velasquez
date: 2016-02-05 10:48:45.000000000

Patch Set 5:

(1 comment)

Line:50, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/wizards/datatransfer/EclipseProjectConfigurator.java -> I don't know how to use those. Should I instantiate a new SubProgressMonitor just to avoid that check?

-------------------------------------
author: Gerrit Code Review
date: 2016-03-11 18:56:24.000000000

Change has been successfully merged into the git repository by Isis Velasquez

-------------------------------------
